Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation] Fix: breadcrumb is not correct when clicking inspect / edit in Assets page #7825

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9dd9b14 from #7749.

…dit in Assets page (#7749)

* settings header

Signed-off-by: tygao <[email protected]>

* update all pages header

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #7744 created/updated

* style: update management style

Signed-off-by: tygao <[email protected]>

* remove extra spacer

Signed-off-by: tygao <[email protected]>

* add tests and snapshots

Signed-off-by: tygao <[email protected]>

* feat: jump to standard application when the toggle is on

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7749 created/updated

* feat: improve test coverage

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9dd9b14)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (90ffd77) to head (137679a).
Report is 6 commits behind head on 2.x.

Files Patch % Lines
...section/objects_table/components/relationships.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7825   +/-   ##
=======================================
  Coverage   63.90%   63.91%           
=======================================
  Files        3657     3657           
  Lines       81244    81249    +5     
  Branches    12949    12951    +2     
=======================================
+ Hits        51916    51927   +11     
+ Misses      26151    26138   -13     
- Partials     3177     3184    +7     
Flag Coverage Δ
Linux_1 30.12% <0.00%> (-0.01%) ⬇️
Linux_2 55.99% <ø> (ø)
Linux_3 40.48% <0.00%> (-0.01%) ⬇️
Linux_4 31.47% <88.88%> (+0.02%) ⬆️
Windows_1 30.14% <0.00%> (-0.01%) ⬇️
Windows_2 55.94% <ø> (ø)
Windows_3 40.48% <0.00%> (-0.01%) ⬇️
Windows_4 31.47% <88.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit a128621 into 2.x Aug 26, 2024
69 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports bug Something isn't working distinguished-contributor failed changeset navigation v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants