[navigation] Fix: breadcrumb is not correct when clicking inspect / edit in Assets page #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7749 +/- ##
==========================================
+ Coverage 63.80% 63.81% +0.01%
==========================================
Files 3656 3656
Lines 81205 81210 +5
Branches 12950 12952 +2
==========================================
+ Hits 51809 51822 +13
+ Misses 26215 26201 -14
- Partials 3181 3187 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu and
manasvinibs
as code owners
SuZhou-Joe
requested review from
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
ruanyl
approved these changes
Aug 23, 2024
ananzh
approved these changes
Aug 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
…dit in Assets page (#7749) * settings header Signed-off-by: tygao <[email protected]> * update all pages header Signed-off-by: tygao <[email protected]> * Changeset file for PR #7744 created/updated * style: update management style Signed-off-by: tygao <[email protected]> * remove extra spacer Signed-off-by: tygao <[email protected]> * add tests and snapshots Signed-off-by: tygao <[email protected]> * feat: jump to standard application when the toggle is on Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR #7749 created/updated * feat: improve test coverage Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: tygao <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9dd9b14) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 26, 2024
…dit in Assets page (#7749) (#7825) * settings header * update all pages header * Changeset file for PR #7744 created/updated * style: update management style * remove extra spacer * add tests and snapshots * feat: jump to standard application when the toggle is on * Changeset file for PR #7749 created/updated * feat: improve test coverage --------- (cherry picked from commit 9dd9b14) Signed-off-by: tygao <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 2.16 we migrate 4 sub applications
Assets/Data source management/Index pattern management/Application settingsto standard applications and registered into new left nav. But the breadcrumbs info inside some of the pages are not correct. So we need to make sure the link redirect users to correct page instead of the sub pages.Issues Resolved
Screenshot
Before fix
20240823142114722.mp4
After fix
20240823141851065.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration