Skip to content

Enable Shortcuts to Comment Lines in Query Editor #10545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angle943 merged 2 commits into from
Sep 20, 2025
Merged

Enable Shortcuts to Comment Lines in Query Editor #10545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
624dbaa
Enable Shortcuts to Comment Lines in Query Editor
LDrago27 Sep 19, 2025
ee4701c
Changeset file for PR #10545 created/updated
opensearch-changeset-bot[bot] Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/10545.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
feat:
- Enable Shortcuts to Comment Lines in Query Editor ([#10545](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10545))
1 change: 1 addition & 0 deletions packages/osd-monaco/src/monaco.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ import 'monaco-editor/esm/vs/editor/contrib/suggest/browser/suggestController';
import 'monaco-editor/esm/vs/editor/contrib/hover/browser/hoverContribution'; // For hover
import 'monaco-editor/esm/vs/editor/contrib/parameterHints/browser/parameterHints'; // For parameter hints
import 'monaco-editor/esm/vs/editor/contrib/format/browser/formatActions'; // For document formatting
import 'monaco-editor/esm/vs/editor/contrib/comment/browser/comment'; // For comment/uncomment support

export { monaco };
4 changes: 4 additions & 0 deletions ...omponents/query_panel/query_panel_editor/use_query_panel_editor/use_query_panel_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ const languageConfiguration: LanguageConfiguration = {
{ open: "'", close: "'" },
{ open: '`', close: '`' },
],
comments: {
lineComment: '//', // line comment
blockComment: ['/*', '*/'], // block comment
},
Copy link
Copy Markdown
Collaborator

@angle943 angle943 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you see if there was a test that checks for these other stuff? if there was, might be worth adding this one too so that test fails if someone does something to it by accidently in the future

Copy link
Copy Markdown
Collaborator Author

@LDrago27 LDrago27 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a test for it right now. We can add a cypress test for it.

wordPattern: /@?\w[\w@'.-]*[?!,;:"]*/, // Consider tokens containing . @ as words while applying suggestions. Refer https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10118#discussion_r2201428532 for details.
};

Expand Down
Loading