Enable Shortcuts to Comment Lines in Query Editor#10545
Enable Shortcuts to Comment Lines in Query Editor#10545angle943 merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
❌ Invalid PrefixInvalid description prefix. Found "feat ". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10545 +/- ##
==========================================
- Coverage 62.14% 62.14% -0.01%
==========================================
Files 4299 4299
Lines 110328 110328
Branches 18199 18199
==========================================
- Hits 68565 68563 -2
- Misses 37083 37085 +2
Partials 4680 4680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| comments: { | ||
| lineComment: '//', // line comment | ||
| blockComment: ['/*', '*/'], // block comment | ||
| }, |
There was a problem hiding this comment.
can you see if there was a test that checks for these other stuff? if there was, might be worth adding this one too so that test fails if someone does something to it by accidently in the future
There was a problem hiding this comment.
I don't think there is a test for it right now. We can add a cypress test for it.
|
Will merge this once the Grammar upgrade is merged in. #10536 . Since without the grammar upgrade the parser won't recognize the comments as valid PPL token. |
Description
This enables Shortcuts to Comment Lines in Query Editor.
cmd + /to comment/uncomment a lineshift+ option + /to comment/uncomment a selected blockIssues Resolved
Screenshot
Testing the changes
Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.28.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration