Fix npm and NuGet version mismatch across CI jobs - #6937
Closed
knutwannheden wants to merge 1 commit into
Closed
Conversation
The npm-publish workflow runs as a separate job with a fresh checkout, so it lost the version determined during build/release. For releases like v8.75.3, this caused npm to publish 8.76.0-20260311-003608 instead. - Accept npm_version from upstream workflow and pass it as Gradle property - Add npmVersion Gradle property support to rewrite-javascript build - Fix rewrite-csharp to read version.txt before generating a fresh timestamp (same fix Python/JS already had from 750bc71) - Pass npm_version from build/release job outputs in ci.yml and publish.yml
Contributor
|
This PR is stale because it has been open for 90 days with no activity. Remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept
npm_versioninput innpm-publish.ymland pass it as-PnpmVersionGradle propertyAdd
npmVersionGradle property support torewrite-javascript/build.gradle.kts(highest priority override)Fix
rewrite-csharp/build.gradle.ktsto read fromversion.txtbefore generating a fresh timestamp (same fix Python/JS already had from 750bc71)Pass
npm_versionfrom build/release job outputs inci.ymlandpublish.ymlCompanion PR: Pass npm version as job output for cross-job consistency gh-automation#88
Context
The npm-publish workflow was decoupled into a separate job in 0947a14. Since it does a fresh checkout, it loses the version.txt written during build. For the release of
v8.75.3, this caused npm to publish8.76.0-20260311-003608because Nebula computed the next snapshot version without-Prelease.useLastTag=true.The C# NuGet version also had a latent mismatch bug for snapshots — it was never updated with the version.txt-reading fix from 750bc71 that Python and JS received.
Test plan