Pass npm version as job output for cross-job consistency - #88
Draft
knutwannheden wants to merge 1 commit into
Draft
Pass npm version as job output for cross-job consistency#88knutwannheden wants to merge 1 commit into
knutwannheden wants to merge 1 commit into
Conversation
The npm-publish job runs in a separate workflow job with a fresh checkout, so it cannot read the version.txt file written during the build/release job. This caused release builds (e.g. v8.75.3) to publish the wrong npm version (e.g. 8.76.0-20260311-003608) because Nebula computed a snapshot version without -Prelease.useLastTag=true. Extract the npm version from rewrite-javascript-version.txt after build/publish and expose it as a workflow output so callers can pass it to the npm-publish job.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewrite-javascript-version.txtafter build/publish and expose it as a workflow outputopenrewrite/rewrite) can pass this version to thenpm-publishjob so it publishes the correct versionCompanion PR: openrewrite/rewrite (pending)
Context
The npm-publish job runs in a separate workflow job with a fresh checkout, so it cannot read the version.txt file written during the build/release job. This caused release builds (e.g.
v8.75.3) to publish the wrong npm version (e.g.8.76.0-20260311-003608) because Nebula computed a snapshot version without-Prelease.useLastTag=true.Test plan