Wrapping the adding of the dependency for org.projectlombok:lombok-mapstruct-binding in a check to make sure you do not already have said dependency (potentially in another scope)#944
Merged
steve-aom-elliott merged 2 commits intomainfrom Nov 17, 2025
Conversation
…apstruct-binding` in a check to make sure you do not already have said dependency (potentially in another scope)
timtebeek
approved these changes
Nov 15, 2025
steve-aom-elliott
deleted the
1632-fixing-duplicate-lombok-mapstruct-binding-add
branch
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Nov 24, 2025
…21.2 to 3.22.0 [skip ci] [//]: # (dependabot-start)⚠️ \*\*Dependabot is rebasing this PR\*\*⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [org.openrewrite.recipe:rewrite-migrate-java](https://github.com/openrewrite/rewrite-migrate-java) from 3.21.2 to 3.22.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-migrate-java's releases](https://github.com/openrewrite/rewrite-migrate-java/releases).* > 3.22.0 > ------ > > What's Changed > -------------- > > * Handle `JaxbAnnotationIntrospector` and `JacksonJsonProvider` in migration by [`@CalvinZengyi`](https://github.com/CalvinZengyi) in [openrewrite/rewrite-migrate-java#936](https://github.com/openrewrite/rewrite-migrate-java/pull/936) > * Also change Gradle classifier for Apache Shiro by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#939](https://github.com/openrewrite/rewrite-migrate-java/pull/939) > * Remove dependency version upgrade for commons-fileupload by [`@hendrikebbers`](https://github.com/hendrikebbers) in [openrewrite/rewrite-migrate-java#943](https://github.com/openrewrite/rewrite-migrate-java/pull/943) > * Convert `Iterables.all(Collection, Predictate)` into `.stream().allMatch(Predicate)` by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#945](https://github.com/openrewrite/rewrite-migrate-java/pull/945) > * Wrapping the adding of the dependency for `org.projectlombok:lombok-mapstruct-binding` in a check to make sure you do not already have said dependency (potentially in another scope) by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-migrate-java#944](https://github.com/openrewrite/rewrite-migrate-java/pull/944) > * Update jakarta-ee-10.yml by [`@ChenyuWang98`](https://github.com/ChenyuWang98) in [openrewrite/rewrite-migrate-java#946](https://github.com/openrewrite/rewrite-migrate-java/pull/946) > * Use ChangeType for classes renamed in fastjson2 by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-migrate-java#948](https://github.com/openrewrite/rewrite-migrate-java/pull/948) > > New Contributors > ---------------- > > * [`@CalvinZengyi`](https://github.com/CalvinZengyi) made their first contribution in [openrewrite/rewrite-migrate-java#936](https://github.com/openrewrite/rewrite-migrate-java/pull/936) > * [`@hendrikebbers`](https://github.com/hendrikebbers) made their first contribution in [openrewrite/rewrite-migrate-java#943](https://github.com/openrewrite/rewrite-migrate-java/pull/943) > > **Full Changelog**: <openrewrite/rewrite-migrate-java@v3.21.2...v3.22.0> Commits * [`fadd76b`](openrewrite/rewrite-migrate-java@fadd76b) OpenRewrite recipe best practices * [`0018845`](openrewrite/rewrite-migrate-java@0018845) Use ChangeType for classes renamed in fastjson2 ([#948](https://github.com/openrewrite/rewrite-migrate-java/issues/948)) * [`0208055`](openrewrite/rewrite-migrate-java@0208055) Update jakarta-ee-10.yml ([#946](https://github.com/openrewrite/rewrite-migrate-java/issues/946)) * [`f13464e`](openrewrite/rewrite-migrate-java@f13464e) Wrapping the adding of the dependency for `org.projectlombok:lombok-mapstruct... * [`a272a5a`](openrewrite/rewrite-migrate-java@a272a5a) Update documentation examples * [`7112826`](openrewrite/rewrite-migrate-java@7112826) [Auto] SDKMAN! Java candidates as of 2025-11-17T1017 * [`b17a592`](openrewrite/rewrite-migrate-java@b17a592) Convert `Iterables.all(Collection, Predictate)` into `.stream().allMatch(Pred... * [`c47788e`](openrewrite/rewrite-migrate-java@c47788e) Add `AnnotateRequiredParameters` to `JSpecifyBestPractices` * [`43d728a`](openrewrite/rewrite-migrate-java@43d728a) Remove dependency version upgrade for commons-fileupload ([#943](https://github.com/openrewrite/rewrite-migrate-java/issues/943)) * [`5c0539e`](openrewrite/rewrite-migrate-java@5c0539e) Also change Gradle classifier for Apache Shiro ([#939](https://github.com/openrewrite/rewrite-migrate-java/issues/939)) * Additional commits viewable in [compare view](openrewrite/rewrite-migrate-java@v3.21.2...v3.22.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Previously there was a scenario wherein if you already had dependencies on
org.projectlombok:lombokandorg.mapstruct:mapstructas well as a dependency onorg.projectlombok:lombok-mapstruct-binding(atprovidedscope for example (which would be best practice), it would end up addingorg.projectlombok:lombok-mapstruct-bindingatcompilescope (asscopewas not provided).This change checks to make sure you just don't have the dependency at all now prior to calling the Maven
AddDependencyto addorg.projectlombok:lombok-mapstruct-binding.What's your motivation?
Was causing duplicate dependencies.
Anything in particular you'd like reviewers to focus on?
Possible that it would be better to be more specific about which scopes we want to consider for the precondition, though I don't think I've ever seen someone add
lombok-mapstruct-bindingintestscope for example, so it might be fine.Checklist