Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation of PDF error messages #467

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

SteffenR2D2
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #467 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #467   +/-   ##
==============================================
  Coverage          49.36%   49.36%           
  Complexity           969      969           
==============================================
  Files                 55       55           
  Lines               7666     7666           
  Branches            1392     1392           
==============================================
  Hits                3784     3784           
  Misses              3422     3422           
  Partials             460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd25d0f...f0ece38. Read the comment docs.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SteffenR2D2 this is fine, I'll be able to review it properly a little later and suggest changes. I'm not approving or rejecting right now.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SteffenR2D2 , the file structure is fine, it's only the location and name that need changing. The file should live in the appropriate resources area for the particular module. In the case of the PDF module that's jhove/jhove-modules/pdf-hul/src/main/resources/edu/harvard/hul/ois/jhove/module/pdf/ErrorMessages_de.properties. I can do the renames if necessary.

@carlwilson carlwilson changed the title ErrorMessages.properties German German translation of PDF error messages Sep 9, 2019
@carlwilson carlwilson added this to the Doc hack week October 2019 milestone Oct 16, 2019
@carlwilson carlwilson added feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release hacktoberfest labels Oct 16, 2019
@carlwilson carlwilson merged commit f0ece38 into openpreserve:integration Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants