Skip to content

CLI cleanups#810

Merged
jjhursey merged 2 commits intoopenpmix:masterfrom
rajachan:cli-cleanup
Mar 11, 2021
Merged

CLI cleanups#810
jjhursey merged 2 commits intoopenpmix:masterfrom
rajachan:cli-cleanup

Conversation

@rajachan
Copy link
Member

@rajachan rajachan commented Mar 8, 2021

commit 4e324b5e369b120bb0386aebb3d4fcc8d55ad89f
Author: Raghu Raja <craghun@amazon.com>
Date:   Mon Mar 8 07:01:09 2021 +0000

    Limit --default-hostfile to prterun and prte

    This specifies the total set of machines available which is useful for
    unmanaged environments. The --hostfile/--host options can choose a
    subset from this larger set. This option is meant to be global in
    nature, and set by an admin or whoever controls the job launch in the
    allocation.

    Ref: https://github.com/openpmix/prrte/issues/709

    Signed-off-by: Raghu Raja <craghun@amazon.com>

commit 605313ad7997b61e25afd57bec8a576e0fed69fe
Author: Raghu Raja <craghun@amazon.com>
Date:   Tue Feb 16 00:55:49 2021 +0000

    prte: Remove stale CLI options.

    Remove report-pids, do-not-resolve, and index-argv-by-rank CLI options.

    Ref: https://github.com/openpmix/prrte/issues/709

    Signed-off-by: Raghu Raja <craghun@amazon.com>

@jjhursey
Copy link
Member

jjhursey commented Mar 8, 2021

For man page cleanup, please request changes on #773 so they are not lost.

@rhc54
Copy link
Contributor

rhc54 commented Mar 8, 2021

@jjhursey Do you want me to hold off this commit?

@jjhursey
Copy link
Member

jjhursey commented Mar 9, 2021

I just merged PR #773 so this will need to be rebased to fix the prtun.1.md conflict. Then I think it's good to go.

rajachan added 2 commits March 9, 2021 17:18
Remove report-pids, do-not-resolve, and index-argv-by-rank CLI options.

Ref: #709

Signed-off-by: Raghu Raja <craghun@amazon.com>
This specifies the total set of machines available which is useful for
unmanaged environments. The --hostfile/--host options can choose a
subset from this larger set. This option is meant to be global in
nature, and set by an admin or whoever controls the job launch in the
allocation.

Ref: #709

Signed-off-by: Raghu Raja <craghun@amazon.com>
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jjhursey jjhursey merged commit bf5ce55 into openpmix:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants