Add prterun manpage, cleanup other manpages#773
Conversation
|
This PR reflects the behavior of the master branch as of today. It does not reflect the changes that we wish to make as noted here. We can update the man pages as those changes come in. |
|
There are three open issues noted in the documentation:
I can remove those examples from the man pages for now, and we can add them back when the tickets are fixed. Or leave the examples, and when those tickets are fixed they can remove the |
05bc45d to
40cb52a
Compare
* Add a `prterun.1` manpage that mostly references other pages to
avoid too much redundancy.
* Split out the map/rank/bind discussion to a stand alone man
page since it is shared by `prun` and `prterun` (and, one could
argue `PMIx_Spawn` in the context of PRTE). Additionally, it
is quite expansive so this provides a single place to provide
additional examples and notes on the interplay of these three
operations.
- Add a soft link for `prte-rank.1` and `prte-bind.1` which
link to `prte-map.1` for ease of use.
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
This should be ready for review now (had to fix a couple of build issues). It's probably easier to view the whole files than try to read the diffs since a bunch of stuff moved around. |
|
PR #774 added the qualifier Note to self - there may be other qualifiers that need to be documented. I just picked up the ones advertised in the |
* Add some more deprecated CLI options * Replace the use of deprecated CLI options with their new forms. * Remove the 'physical' mode of rankfile since it does not exist * Fix rankfile examples to not use the socket specifier logic since it is not working. The new examples just use a core listing. Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Looking at the man page after my comment above I noticed a few other deprecated options that needed to be listed. I also cleaned up the rankfile examples. I commented out the examples associated with open bugs. That makes the manpage correct when rendered, and easy for us to add back those examples once the bugs are fixed. |
* Now that openpmix#772 is fixed * Add Difference between overloading and oversubscription Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
I just pushed a couple of additions
I'll work on the review comments this evening. |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Added back the MIMD example now that Issue #771 is fixed |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Interesting CI failed in cycle with gist There are no code changes in this PR. But this is something we should track down. bot:ibm:gnu:retest |
|
bot:ibm:gnu:retest |
|
Here is my take on that error, though I haven't investigated enough to prove/disprove it. You are running a lot of Issue would be: what happens if the leftover bytes didn't result in a ridiculous size, and we actually tried to parse that as a legitimate message? My guess would be: ouch! |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
I just pushed the clarification from #673 (comment) |
|
For the error I mentioned above I filed #787 for further discussion/debug - since it's not related to this PR. |
|
Reviewers: This is ready for review. There is one outstanding bug (Issue #770) with There are probably other improvements to the man page that we can bring in over time as well. |
|
|
||
| : Synonym for `--wdir`. | ||
|
|
||
| `-x <env>` |
There was a problem hiding this comment.
Sounds like CLI details are in flux and tricky with OMPI/PRRTE separation (#795), but a simple "requires --personality ompi" in the description for -x here might save a lot of pain.
There was a problem hiding this comment.
Interesting. @rhc54 is -x intended to only be for the OMPI personality? It seems like something that should be part of the core.
|
We are starting to get conflicts with other PRs making changes to the man pages. Can I get a review on this so we can all work from the same base? |
rhc54
left a comment
There was a problem hiding this comment.
LGTM - we can always update as we go, but this is a solid base. Thx!
prterun.1manpage that mostly references other pages toavoid too much redundancy.
page since it is shared by
prunandprterun(and, one couldargue
PMIx_Spawnin the context of PRTE). Additionally, itis quite expansive so this provides a single place to provide
additional examples and notes on the interplay of these three
operations.
prte-rank.1andprte-bind.1whichlink to
prte-map.1for ease of use.