Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

040 debug save review #41

Merged
merged 9 commits into from
Jul 19, 2024
Merged

040 debug save review #41

merged 9 commits into from
Jul 19, 2024

Conversation

LDSamson
Copy link
Collaborator

@LDSamson LDSamson commented Jun 28, 2024

Fixes #40 .

The png snapshot updates are all the same: the toggle for adding comments is now disabled (grey) in them (top left)

LDSamson added 2 commits June 28, 2024 17:09
… only a comment is added

(cherry picked from commit ac74caf661c18d1ffb39de11f3f503182a9a8eb7)
(cherry picked from commit e09b3e4a2100b91a9e12a66d0baacb7c231ad662)
@LDSamson LDSamson changed the base branch from main to dev June 28, 2024 15:13
@LDSamson LDSamson requested a review from aclark02-arcus June 28, 2024 15:47
@LDSamson
Copy link
Collaborator Author

@aclark02-arcus were you able to have a look at this? It would be great if we can merge it with the dev branch somewhere this week.

Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LDSamson, this looks good! However, I just wanted to make sure that this action (below) is okay or if the text box should also be disabled? Below I change the review state and compose a comment when marking as "reviewed". But then I also add a new comment when saving as "not reviewed". Does that comment get saved? Is that the intended behavior? Thanks!

snagit_clinsight_save_review_comment

@LDSamson
Copy link
Collaborator Author

Thanks for spotting this! It's indeed better if that field is also disabled. I will work on a fix at the latest tomorrow morning.

@LDSamson
Copy link
Collaborator Author

@aclark02-arcus I will go ahead and merge this. if you find something wrong with the additional changes, please let me know then we can fix it at a later time.

@LDSamson LDSamson merged commit 62c4659 into dev Jul 19, 2024
2 checks passed
@LDSamson LDSamson deleted the 040_debug_save_review branch July 24, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a review comment without changing review state gives an error
2 participants