-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
040 debug save review #41
Conversation
… only a comment is added (cherry picked from commit ac74caf661c18d1ffb39de11f3f503182a9a8eb7)
(cherry picked from commit e09b3e4a2100b91a9e12a66d0baacb7c231ad662)
@aclark02-arcus were you able to have a look at this? It would be great if we can merge it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LDSamson, this looks good! However, I just wanted to make sure that this action (below) is okay or if the text box should also be disabled? Below I change the review state and compose a comment when marking as "reviewed". But then I also add a new comment when saving as "not reviewed". Does that comment get saved? Is that the intended behavior? Thanks!
Thanks for spotting this! It's indeed better if that field is also disabled. I will work on a fix at the latest tomorrow morning. |
@aclark02-arcus I will go ahead and merge this. if you find something wrong with the additional changes, please let me know then we can fix it at a later time. |
Fixes #40 .
The png snapshot updates are all the same: the toggle for adding comments is now disabled (grey) in them (top left)