Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a review comment without changing review state gives an error #40

Closed
LDSamson opened this issue Jun 28, 2024 · 0 comments · Fixed by #41
Closed

Saving a review comment without changing review state gives an error #40

LDSamson opened this issue Jun 28, 2024 · 0 comments · Fixed by #41
Assignees
Labels
bug Something isn't working
Milestone

Comments

@LDSamson
Copy link
Collaborator

Steps to reproduce the problem:

  • Run the test application in development mode (golem::run_dev())
  • Browse to subject BEL_04_772 and page CBC Regular
  • Add a comment in the reviewing pane (top left), and click Save

The following error will show up:

image

Not a critical error, but it is confusing: the save button should not be activated for only a comment. It should only be activated when changing the review state (e.g. the form is not yet reviewed, but the check box is set to 'Reviewed'.

@LDSamson LDSamson added this to the v0.1.0 milestone Jun 28, 2024
@LDSamson LDSamson self-assigned this Jun 28, 2024
@LDSamson LDSamson added the bug Something isn't working label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant