ci: adjustments after next@16 stable release #3195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
commented
Oct 22, 2025
Comment on lines
+62
to
+79
| - name: Resolve Next.js version | ||
| id: resolve-next-version | ||
| shell: bash | ||
| run: | | ||
| RESOLVED_VERSION=$(npm view next@${{ matrix.version }} version) | ||
| echo "version=$RESOLVED_VERSION" >> $GITHUB_OUTPUT | ||
| echo "Resolved Next.js version for 'next@${{ matrix.version }}' is '$RESOLVED_VERSION'" | ||
| - name: Decide Node Version | ||
| id: decide-node-version | ||
| shell: bash | ||
| run: | | ||
| NODE_VERSION=18.x | ||
| if [ "${{ matrix.version}}" = "canary" ]; then | ||
| # this is not ideal, because we set node@20 just when explicitly using canary tag as target | ||
| # but next@canary are still on 15 major, so we can't yet use major version of resolved next version | ||
| # as condition | ||
| if [[ "${{ steps.resolve-next-version.outputs.version }}" == "16."* ]]; then | ||
| # Next@16 requires Node.js 20+ | ||
| NODE_VERSION=20.x | ||
| fi | ||
| echo "version=$NODE_VERSION" >> $GITHUB_OUTPUT | ||
| echo "Node version for 'next@${{ matrix.version }}' is '$NODE_VERSION'" | ||
| - name: 'Install Node' | ||
| echo "Node version for 'next@${{ steps.resolve-next-version.outputs.version }}' is '$NODE_VERSION'" |
There was a problem hiding this comment.
this is pretty much the change repeated in couple of places:
- move
Resolve Next.js versionstep to be beforeDecide Node Version - if resolved next version starts with
16.- use node@20, otherwise - use node@18 (and for next.js repo tests also use same logic to decide if default bundler is webpack or turbopack). We were checking if we testnext@canarybefore because minimum node version bump landed in v15 canaries (but only was released in v16 stable)
everything else in github action workflows is just prettier auto-formatting which makes the diff messy
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Oct 22, 2025
Comment on lines
-19
to
-22
|
|
||
| export const config = { | ||
| runtime: 'nodejs', | ||
| } |
There was a problem hiding this comment.
this cause build failures now:
[proxy-i18n-skip-normalize] > Build error occurred
[proxy-i18n-skip-normalize] Error: Route segment config is not allowed in Proxy file at "./proxy.ts". Proxy always runs on Node.js runtime. Learn more: https://nextjs.org/docs/messages/middleware-to-proxy
Note that this test fixture was added yesterday specifically for next@16 while there were lot of Next.js PRs still in flight and I wasn't sure what the handling will be - see #3190 (review)
pieh
changed the title
pieh
commented
Oct 22, 2025
Comment on lines
+44
to
+47
| return ( | ||
| (isNextCanary() && nextVersionSatisfies('>=15.5.1-canary.4')) || | ||
| nextVersionSatisfies('>=16.0.0') | ||
| ) |
There was a problem hiding this comment.
Another change that graduated from canary-only to be enabled in stable releases (this is used in our tests only to make correct assertions, it doesn't change actual support for it)
eduardoboucas
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of these are adjustments to tests and test setup:
canarywhen deciding to use node@20 (which is now minimun node version needed for next@16), but now with next@16 stable release this no longer make sense to do, so now we finally check major of resolved next version to decide node version