fix: support skipProxyUrlNormalize #3190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test latest and canary
pieh
force-pushed
the
fix/support-skipProxyUrlNormalize
branch
from
ae9bc22 to
549cfd0
Compare
pieh
commented
Oct 21, 2025
Comment on lines
+696
to
+706
|
|
||
| const responseData = await invokeEdgeFunction(ctx, { | ||
| functions: [edgeFunctionNameRoot], | ||
| origin, | ||
| url: `/_next/data/build_id/en/dynamic/test.json?slug=test`, | ||
| }) | ||
|
|
||
| expect( | ||
| responseData.headers.get('x-next-url-pathname'), | ||
| 'nextUrl.pathname should not be normalized due to skipMiddlewareUrlNormalize', | ||
| ).toEqual('/_next/data/build_id/en/dynamic/test.json') |
There was a problem hiding this comment.
uff, we actually didn't have any assertion that skipMiddlewareUrlNormalize was supported - so this adds assertion for now deprecated config option mainly for older Next.js versions
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Oct 21, 2025
Comment on lines
+20
to
+22
| export const config = { | ||
| runtime: 'nodejs', | ||
| } |
There was a problem hiding this comment.
It seems like Proxy will be Node.js only (tho it's not as of now), so I do add this explicitly here in hope the test setup won't break when Next.js ships the change to make Proxy Node.js only. If that change end up not shipping, I'll adjust the setup to run in both Edge and Node.js runtimes as we do for most of our middleware fixtures
serhalp
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
LGTM
For posterity, the breaking change was reverted before v16 stable was released: vercel/next.js#85183. We'll still need this change eventually though, so might as well ship it.
At least we will get some more test coverage for right now 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skipMiddlewareUrlNormalizenext.config option is being deprecated (as part of overallmiddleware->proxyrename) and is being replaced byskipProxyUrlNormalize:This adds support for the renamed config option as we need specific handling for it in our middleware/proxy handling.
Added integration tests asserting that
nextUrlin middleware/proxy is not normalized whenskipMiddlewareUrlNormalize/skipProxyUrlNormalizeis used. Note that while we supportedskipMiddlewareUrlNormalizefor long time, we didn't actually have test for it 😱 , so test is added for both now deprecated and new config option