refactor: do not create a wrangler config when a custom one is passed #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 698f7ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vicb
requested review from
conico974,
dario-piotrowicz,
james-elicx and
sommeeeer
commit: |
james-elicx
reviewed
Oct 13, 2025
vicb
commented
Oct 13, 2025
vicb
force-pushed
the
vicb/create-config
branch
from
4d3da87 to
698f7ce
Compare
|
Thanks for the review and catching the wrong version James! |
james-elicx
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only ask whether to create a config file when no custom one is specified via
--config.Also the check is moved at the beginning of the build at the build aborts when the reply is No.
Both cases (no config, custom config) tested locally.