-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add support for serving assets from the routing layer #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 45003aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the e2es are failing. Logic looks good though.
The value of I'll fix this by setting the value on |
|
Thanks for the review James! |
Implement the recently introduced
AssetResolverBefore this PR all assets had to be served before the app worker (
run_worker_first=falsewhich is the default value)With this PR, when
run_worker_firstis set totruethen the assets will be resolved during the routing phase, after the middleware. We will use that for skew protection as well.(The code also supports when
use_worker_firstis set to an array of patterns)