-
Notifications
You must be signed in to change notification settings - Fork 180
fix(build): Refactor fallback values to be dummy overrides in createEdgeBundle #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): Refactor fallback values to be dummy overrides in createEdgeBundle #975
Conversation
🦋 Changeset detectedLatest commit: b5906f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This reverts commit a7ad1a2.
conico974
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sorry and nevermind all prior message. I read it on my phone and for some reason I thought you removed this line typeof overrides?.[target] === "function"
LGTM Thanks
If you have
enableCacheInterceptionenabledincludeCachewill be true there, meaningesbuildwill potentially bundleaws4fetchand the fallback overrides(sqs-lite,dynamodb-lite&s3-lite) in the middleware handler file. This can happen if you build from the Cloudflare adapter cause theoverridescan contain anonymous functions and theoverridefunction would returnundefined.To see this your self, build the
examples/e2e/app-routerin cloudflare repo and look foraws4fetch,sqs-liteetc.. in the middleware handler file. Do we really need to pass any values here tho? I can't find any of them bundled in the middleware handler, even with this fix.