Fix and enhancement for Next 16 #1029
Conversation
🦋 Changeset detectedLatest commit: 3982bb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Do we have to handle the |
Nope it doesn't change the name of the compiled file, but we have to update to Node 20 for e2e it seems.... |
packages/open-next/src/adapters/plugins/image-optimization/image-optimization.replacement.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Very good job Nico! It seems to pass the E2E locally for me on Next 16.
Just a few comments and also could you rename the middleware files to proxy in all the examples app. (npx @next/codemod@canary middleware-to-proxy .)
To make the E2E work both locally and deployed we need to change this to 20:
And all the Runtime.NODEJS_18_X into Runtime.NODEJS_20_X in OpenNextReferenceImplementation.ts.
Also update package.json here:
Line 28 in 9b7f726
Perhaps remove these lines as we already setup node and pnpm cache in the setup/action.yml :
opennextjs-aws/.github/workflows/e2e.yml
Lines 95 to 99 in 9b7f726
However, we might do this in a seperate PR. Up to you.
| cacheFileMeta && | ||
| Array.isArray(cacheFileMeta.segmentPaths) && |
There was a problem hiding this comment.
| cacheFileMeta && | |
| Array.isArray(cacheFileMeta.segmentPaths) && | |
| Array.isArray(cacheFileMeta?.segmentPaths) && |
There was a problem hiding this comment.
cacheFileMeta.segmentPaths.length > 0 could also be skipped maybe
There was a problem hiding this comment.
Maybe something like:
const segments: Record<string, string> = Array.isArray(cacheFileMeta?.segmentPaths) ?
Object.fromEntries(cacheFileMeta.segmentPaths.map(...)) :
{};
|
Do we have any tests for Could be some weird delimiter character in the user agent that's causing the break, eg |
Is this related to this PR or should it be a different question/issue? |
|
It's unrelated, we can continue the discussion when the person opens a ticket. |
packages/open-next/src/adapters/plugins/image-optimization/image-optimization.replacement.ts
Show resolved
Hide resolved
| expect(response.headers()["cache-control"]).toBe( | ||
| "public, immutable, no-transform, max-age=31536000", | ||
| ); | ||
| // expect(response.headers()["cache-control"]).toBe( |
There was a problem hiding this comment.
what do we want to do with those expectations?
There was a problem hiding this comment.
If next doesn't do it anymore by default, we should remove it (just checked, that's the case in next start).
But I think it's still a good idea to test to add them manually. I keep it in one and not in the other
pnpm-workspace.yaml
Outdated
|
|
||
| catalog: | ||
| next: 15.4.2 | ||
| next: 16.0.0 |
|
Changes LGTM |
There was a problem hiding this comment.
LGTM, let's get this merged?
@sommeeeer I can't retrieve what your requested change was?
It was just this: #1029 (review) |
Should fix most build failures in Next 16.
Support for incremental prefetching (Fix #1022)
Support for incremental prefetching in the cache interceptor
Fix #1026