Allow any status change to include an associated_trip
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR openmobilityfoundation#297 already updated the spec language to make it clear that any status change is allowed to have an `associated_trip`, but I didn't realize this was incompatible with the existing schema. The schema should now match the spec, which states that `user_pick_up` and `user_drop_off` events must have an `associated_trip` but other events may have one when applicable.
thekaveman
approved these changes
Aug 28, 2019
thekaveman
added
Schema
hunterowens
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #297 already updated the spec language to make it clear that any status change is allowed to have an
associated_trip, but I didn't realize this was incompatible with the existing schema. The schema should now match the spec, which states thatuser_pick_upanduser_drop_offevents must have anassociated_tripbut other events may have one when applicable.Is this a breaking change
It's not really clear whether this should be considered a breaking change. I could see arguments either way, but I think it's moot if the intention is for this to be included in the 0.4.0 release.
Provideroragencyprovider