Validation fixes #81
Merged
Validation fixes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously some item errors were incorrectly classified as payload errors makes downstream filtering and validation a little easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of payload level errors where a
oneOfhas multiple matches.The current use-case is for validating against
0.3.2, where the published schema doesn't align with the published spec in thatassociated_tripis allowed on any status event, but the schema has aoneOfcondition for that property.As far as the spec goes, this is being addressed by openmobilityfoundation/mobility-data-specification#353
Also a minor fix to guard against reading an attribute before it exists.