Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflowitem.viewDetails endpoint #947

Merged
merged 4 commits into from
Aug 31, 2021

Conversation

georgimld
Copy link
Collaborator

@georgimld georgimld commented Aug 25, 2021

Description

In order to check whether documents in a workflowitem are available or not, the api must first try to download the document to mark it as available or not. This will be done in a new endpoint workflowitem.viewDetails, that is triggered when a workflowitem is clicked.

TODOs

  • api: add new endpoint and implement on all layers workflowitem.viewDetails
  • api: in the domain layer, try to download the document, mark it's availability
  • frontend: implement new action that triggers the new api call

Closes #944

@georgimld georgimld changed the title Add workflowitem.viewDetails intent Add workflowitem.viewDetails endpoint Aug 25, 2021
@georgimld georgimld force-pushed the 944-unavailable-workflowitem-documents-appear branch from 3eec3eb to 5c90108 Compare August 25, 2021 15:04
@github-actions
Copy link

github-actions bot commented Aug 25, 2021

Warnings
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 668a212

@georgimld georgimld marked this pull request as ready for review August 25, 2021 15:05
@georgimld georgimld force-pushed the 944-unavailable-workflowitem-documents-appear branch from 5c90108 to 3cfa53b Compare August 25, 2021 15:15
@openkfwCI
Copy link

openkfwCI commented Aug 25, 2021

NotesTime
Note for Reviewer: E2E tests on remote server succeededMon, 30 Aug 2021 08:24:51 +0000

Generated by E2E-Test

@georgimld georgimld force-pushed the 944-unavailable-workflowitem-documents-appear branch from 3cfa53b to 668a212 Compare August 30, 2021 07:43
@Stezido Stezido merged commit 59855d0 into master Aug 31, 2021
@Stezido Stezido deleted the 944-unavailable-workflowitem-documents-appear branch August 31, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unavailable Workflowitem Documents appear in Detail View
3 participants