Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unavailable Workflowitem Documents appear in Detail View #944

Closed
laurenzhonauer opened this issue Aug 24, 2021 · 0 comments · Fixed by #947
Closed

Unavailable Workflowitem Documents appear in Detail View #944

laurenzhonauer opened this issue Aug 24, 2021 · 0 comments · Fixed by #947
Assignees
Labels
api Indicates api related issue or feature bug Something isn't working frontend Indicates frontend related issue or feature

Comments

@laurenzhonauer
Copy link
Contributor

laurenzhonauer commented Aug 24, 2021

Description 😯

When viewing the Detail-Page of a Workflow-Item the user can see a list of documents that was attached to the Item.
If this document is, for whatever reason, not available anymore the user still sees a list entry for that missing Item without a name. Also when the user tries to click the download button, a 404 is returned from the Api and the user will get no document. This is confusing for the user

How to reproduce 🕹

Two possibilities

  1. Try to view and download documents that were uploaded with version 1.19.0
  2. Try to view and download documents that were deleted from storage service

How to Fix

Break up workflowitem information in subproject viewDetail into

  • workflowItem - viewSummary - Will represent a list item in the subproject Detail
  • workflowItem - viewDetail - Will contain Document

Workflowitem.viewDetail will mark unavailable Documents so the Frontend will be able to show the user that a document is corrupt / not available for download.

Your Environment 🌎

Tech Version
Frontend v1.24.0
API v1.24.0
@laurenzhonauer laurenzhonauer added the bug Something isn't working label Aug 24, 2021
@issuelabeler issuelabeler bot added api Indicates api related issue or feature frontend Indicates frontend related issue or feature labels Aug 24, 2021
@Stezido Stezido added this to the Trubudget 1.25.0 milestone Aug 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Indicates api related issue or feature bug Something isn't working frontend Indicates frontend related issue or feature
Projects
None yet
2 participants