Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder for empty fields #434

Merged
merged 2 commits into from
May 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- Added search feature for subprojects [#422](https://github.com/openkfw/TruBudget/issues/422)
- Show no permissions assigned warning on subproject/workflowitem create [#441](https://github.com/openkfw/TruBudget/issues/441)
- Placeholders are being shown in case of an empty state [#31](https://github.com/openkfw/TruBudget/issues/31)

<!-- ### Changed -->

Expand Down
7 changes: 6 additions & 1 deletion e2e-test/cypress/integration/global_permissions_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ describe("Users/Groups Dashboard", function() {
cy.login(testUserName, testUserNamePassword);
cy.visit("/users");
});

beforeEach(function() {
cy.login();
cy.visit("/users");
});

it("Display the global permission dialog correctly", function() {
cy.reload();
cy.get(`[data-test=edit-user-permissions-${testUserName}]`).click();
cy.get("[data-test=global-permissions-dialog]").should("be.visible");
cy.get("[data-test=cancel]").click();
Expand Down Expand Up @@ -47,7 +49,10 @@ describe("Users/Groups Dashboard", function() {
});

it("After clicking 'cancel', the selection is not adopted", function() {
cy.get(`[data-test=edit-user-permissions-${testUserName}]`).click();
cy.get(`[data-test=user-${testUserName}]`).should("be.visible");
cy.get(`[data-test=edit-user-permissions-${testUserName}]`)
.should("be.visible")
.click();
cy.get("[data-test=global-permissions-dialog]").should("be.visible");

cy.get("[data-test='permission-global.createUser'] input").should("not.be.checked");
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/cypress/integration/project_analytics_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ describe("Project Analytics", function() {
// Open dialog
cy.get("[data-test=details-analytics-button]")
.should("be.visible")
.click();
.click({ force: true });
mathiashoeld marked this conversation as resolved.
Show resolved Hide resolved
cy.get("[data-test=select-currencies]")
.should("be.visible")
.click();
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/cypress/integration/subproject_analytics_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ describe("Subproject Analytics", function() {
// Open dialog
cy.get("[data-test=details-analytics-button]")
.should("be.visible")
.click();
.click({ force: true });

cy.get("[data-test=number-chart-total-budget]").should("not.be.visible");
cy.get("[data-test=projected-budget-table]").should("be.visible");
Expand Down
14 changes: 12 additions & 2 deletions e2e-test/cypress/integration/subproject_create_spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
describe("Subproject creation", function() {
let projectId;
let baseUrl, apiRoute;

before(() => {
baseUrl = Cypress.env("API_BASE_URL") || `${Cypress.config("baseUrl")}/test`;
apiRoute = baseUrl.toLowerCase().includes("test") ? "/test/api" : "/api";
});

it("Root cannot add a subproject", function() {
const organization = "ACME Corp";
Expand Down Expand Up @@ -27,9 +33,13 @@ describe("Subproject creation", function() {
it("Check warnings that permissions are not assigned", function() {
cy.login();
cy.visit(`/projects/${projectId}`);
cy.server();
cy.route("GET", apiRoute + "/project.viewDetails*").as("loadPage");

//Create a subproject
cy.get("[data-test=subproject-create-button]").click();
cy.wait("@loadPage")
.get("[data-test=subproject-create-button]")
.click();
cy.get("[data-test=nameinput] input").type("Test");
cy.get("[data-test=dropdown-sp-dialog-currencies-click]")
.click()
Expand All @@ -43,7 +53,7 @@ describe("Subproject creation", function() {

//Check warning badge
cy.get("[data-test=warning-badge]").should("be.visible");
cy.get("[data-test=spp-button-0]").click();
cy.get("[data-test=spp-button-0]").click({ force: true });
cy.get("[data-test=warning-badge]").should("not.be.checked");
cy.get("[data-test=permission-submit]").click();
cy.get("[data-test=warning-badge]").should("not.be.checked");
Expand Down
1 change: 1 addition & 0 deletions e2e-test/cypress/integration/subproject_edit_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe("Subproject Edit", function() {
.then(title => {
cy.get("[data-test=nameinput] input").type("-changed");
cy.get("[data-test=submit]").click();
cy.get("[data-test=highlighted-displayname]").should("be.visible");
cy.get("[data-test=subproject-title-0]")
.invoke("text")
.should("not.eq", title);
Expand Down
32 changes: 18 additions & 14 deletions e2e-test/cypress/integration/subproject_search_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ describe("Subproject Search", function() {
cy.login();
cy.visit(`/projects/${projectWithTag.id}`);
});

it("Check regex highlighting", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
cy.get("[data-test=search-input]")
.should("be.visible")
.type("SearchTest");
Expand All @@ -44,23 +46,26 @@ describe("Subproject Search", function() {
});

it("Filter subprojects by display name", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible")
.type(projectWithTag.subprojectTitle);
.should("not.be.disabled");
cy.get("[data-test=search-input").type(projectWithTag.subprojectTitle);
cy.get("[data-test=highlighted-displayname]").contains(projectWithTag.subprojectTitle);
//Only one element should should be in the list
cy.get("[data-test=subproject-title-0]").should("be.visible");
cy.get("[data-test=subproject-title-1]").should("not.be.visible");
});

it("Filter subprojects by prefix 'name' and 'status'", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible")
.type("name:" + projectWithTag.subprojectTitle);
.should("be.visible");
cy.get("[data-test=search-input]").type("name:" + projectWithTag.subprojectTitle);
cy.get("[data-test=highlighted-displayname]").contains(projectWithTag.subprojectTitle);
//Only one element should should be in the list
cy.get("[data-test=subproject-title-0]").should("be.visible");
Expand All @@ -69,7 +74,8 @@ describe("Subproject Search", function() {
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible")
.should("be.visible");
cy.get("[data-test=search-input]")
.type("{selectall}{backspace}")
.type("status: open");
cy.get("[data-test=ssp-table]").contains("Open");
Expand All @@ -79,14 +85,15 @@ describe("Subproject Search", function() {
});

it("Search bar is empty when viewing subproject details", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
// Type into search bar
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible");
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input] input")
.find("[data-test=search-input]")
.type("SearchTestExample");
// Go into detail view
cy.get("[data-test=subproject-view-details-0]").click();
Expand All @@ -99,15 +106,13 @@ describe("Subproject Search", function() {
});

it("Search bar is empty and exists when clicking on 'Main' breadcrumb", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible");
// Type into search bar
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input] input")
.type("SearchTestExample");
cy.get("[data-test=search-input]").type("SearchTestExample");
// Navigate via Main breadcrumb
cy.get("[data-test=breadcrumb-Main]").click();
// Go back to subproject view
Expand All @@ -119,15 +124,14 @@ describe("Subproject Search", function() {
});

it("Search bar is empty and exists when clicking on 'Projects' breadcrumb", function() {
cy.get("[data-test=subproject-row]").should("be.visible");
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input]")
.should("be.visible");
.should("be.visible")
.should("not.be.disabled");
// Type into search bar
cy.get("[data-test=sub-projects]")
.find("[data-test=search-bar]")
.find("[data-test=search-input] input")
.type("SearchTestExample");
cy.get("[data-test=search-input]").type("SearchTestExample");
// Navigate via Projects breadcrumb
cy.get("[data-test=breadcrumb-Projects]").click();
// Go back to subproject view
Expand Down
4 changes: 2 additions & 2 deletions e2e-test/cypress/integration/timestamp_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const standardBudget = [
describe("Timestamps", function() {
before(function() {
cy.login("mstein", "test");
cy.visit(`/projects`);
cy.createProject("p-timestamp", "project timestamp test", standardBudget);
});

Expand All @@ -23,8 +22,9 @@ describe("Timestamps", function() {
.last()
.click();
cy.get("[data-test=assignee-selection]").click();
cy.get("[data-test=assignee-list]")
cy.get("[data-test=assignee-selection]")
.should("be.visible")
.get("[data-test=assignee-list]")
.find("[value=thouse]")
.click()
.get("[data-test=confirmation-dialog-confirm]")
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/cypress/integration/workflowitem_create_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe("Workflowitem create", function() {
cy.get("[data-test=workflowitem-table]")
.find("[data-test=show-workflowitem-permissions]")
.first()
.click();
.click({ force: true });
cy.get("[data-test=warning-badge]")
.first()
.should("not.be.checked");
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/cypress/integration/workflowitem_edit_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe("Workflowitem edit", function() {
// when the workflow item was created
cy.get("[data-test=edit-workflowitem]")
.last()
.click();
.click({ force: true });
cy.get("[data-test=dropdown-currencies-click]").should("contain", "USD");

// Close the dialog
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/cypress/integration/workflowitem_history_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe("Workflowitem's history", function() {
});

it("When changing the tab, the history is fetched correctly", function() {
cy.get(".workflowitem-info-button").click();
cy.get(`[data-test^='workflowitem-info-button-${workflowitemId}']`).click();

// opens info dialog window..

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion frontend/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ const muiTheme = createMuiTheme({
warning: amber[800],
info: blue,
grey: {
main: grey[100]
light: grey[100],
main: grey[400],
dark: grey[600]
},
tonalOffset: 0.6
},
Expand Down
17 changes: 15 additions & 2 deletions frontend/src/languages/english.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,22 @@ const en = {
invalid_tag: "Invalid tag",
name: "Name",
next: "Next",
no_budget: "No budget found",
no_budget_project: "To add a budget for your project, navigate back to the main page.",
no_budget_subproject: "To add a budget for your subproject, navigate back to the subproject overview page.",
no_budget_distribution: "Unable to display distribution if not all items are visible",
no_groups: "No groups found",
no_groups_text: "Create a new group by pressing the plus button.",
no_history: "No events",
no_items_text: "You can create one by pressing the plus button.",
no_nodes: "No requests for additonal nodes found",
no_notifications: "No notifications found",
no_organizations: "No requests for new organizations found",
no_resources: "No fields were added to this Resource",
no_subprojects: "No subprojects found",
no_users: "No users found",
no_users_text: "Add a new user by pressing the plus button.",
no_workflow_items: "No workflow items found",
not_assigned_budget: "Not Assigned Budget",
not_assigned: "Not assigned",
not_disbursed: "Not disbursed",
Expand Down Expand Up @@ -124,11 +137,11 @@ const en = {

nodesDashboard: {
access: "Access",
additional_organization_node: "New nodes for existing organizations",
additional_organization_node: "Requests for Additional Nodes",
address: "Address",
approve: "Approve",
network: "Network",
new_organization: "New Organizations",
new_organization: "Requests for New Organizations",
nodes: "Nodes",
permissions: "Permissions"
},
Expand Down
18 changes: 16 additions & 2 deletions frontend/src/languages/french.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,23 @@ const fr = {
invalid_tag: "Tag invalide",
name: "Nom",
next: "Suivant",
no_budget: "Aucun budget trouvé",
no_budget_project: "Pour ajouter un budget à votre projet, retournez à la page principale.",
no_budget_subproject:
"Pour ajouter un budget à votre composante, retournez à la page de présentation du composante.",
no_budget_distribution: "Impossible d'afficher la distribution si tous les éléments ne sont pas visibles",
no_groups: "Aucun groupe trouvé",
no_groups_text: "Créez un nouveau groupe en appuyant sur la touche plus.",
no_history: "Aucun évenement",
no_items_text: "Vous pouvez en créer un en appuyant sur la touche plus.",
no_nodes: "Aucune demande de nœuds supplémentaires n'a été trouvée",
no_notifications: "Aucune notification trouvée",
no_organizations: "Aucune demande de nouvelles organisations n'a été trouvée",
no_resources: "Aucun champ n'a été ajouté à cette ressource",
no_subprojects: "Aucun composante trouvé",
no_users: "Aucun utilisateur trouvé",
no_users_text: "Ajoutez un nouvel utilisateur en appuyant sur le touche plus.",
no_workflow_items: "Aucun élément trouvé",
not_assigned_budget: "Budget non-alloué",
not_assigned: "Non alloué",
not_disbursed: "Non décaissé",
Expand Down Expand Up @@ -231,11 +245,11 @@ const fr = {

nodesDashboard: {
access: "Accès",
additional_organization_node: "Nouveaux nœuds pour les organisations existantes",
additional_organization_node: "Demandes de nœuds supplémentaires",
address: "Adresse",
approve: "Approuver",
network: "Réseau",
new_organization: "Nouvelles organisations",
new_organization: "Demandes de nouvelles organisations",
nodes: "Noeuds",
permissions: "Autorisations"
},
Expand Down
21 changes: 17 additions & 4 deletions frontend/src/languages/georgian.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,22 @@ const ka = {
invalid_tag: "თაგი არასწორია",
name: "სახელი",
next: "შემდეგ",
no_budget: "ბიუჯეტი ვერ მოიძებნა",
no_budget_project: "თქვენი პროექტის ბიუჯეტის დასამატებლად გადადით მთავარ გვერდზე.",
no_budget_subproject: "თქვენი ქვეპროექტისთვის ბიუჯეტის დასამატებლად გადადით უკან ქვეპროექტის მიმოხილვის გვერდზე.",
no_budget_distribution: "ბიუჯეტის განაწილება შეუძლებელია თუ ყველა ელემენტი არ ჩანს",
no_history: "No events",
no_resources: "No fields were added to this Resource",
no_groups: "ჯგუფები არ მოიძებნა",
no_groups_text: "შექმენით ახალი ჯგუფი plus ღილაკის დაჭერით.",
no_history: "არანაირი მოვლენა",
no_items_text: "თქვენ შეგიძლიათ შექმნათ პლიუსის ღილაკის დაჭერით.",
no_nodes: "დამატებითი კვანძების მოთხოვნა ვერ მოიძებნა",
no_notifications: "შეტყობინებები ვერ მოიძებნა",
no_organizations: "ახალი ორგანიზაციების მოთხოვნა ვერ მოიძებნა",
no_resources: "არცერთი ველი არ დაემატა ამ რესურსს",
no_subprojects: "ქვეპროექტი ვერ მოიძებნა",
no_users: "მომხმარებლები ვერ მოიძებნა",
no_users_text: "დაამატეთ ახალი მომხმარებელი, ღილაკის დამატების ღილაკის დაჭერით.",
no_workflow_items: "სამუშაო პროცესის ელემენტები ვერ მოიძებნა",
not_assigned_budget: "ბიუჯეტი რომელიც განაწილებული არ არის",
not_assigned: "არ არის გამოყოფილი",
not_disbursed: "არ არის გადმორიცხული",
Expand Down Expand Up @@ -124,11 +137,11 @@ const ka = {

nodesDashboard: {
access: "წვდომა",
additional_organization_node: "ახალი node-ები არსებული ორგანიზაციებისთვის",
additional_organization_node: "მოთხოვნები დამატებითი კვანძებისთვის",
address: "მისამართი",
approve: "დადასტურება",
network: "ქსელი",
new_organization: "ახალი ორგანიზაციები",
new_organization: "მოთხოვნები ახალი ორგანიზაციებისთვის",
nodes: "Nodes",
permissions: "ნებართვები"
},
Expand Down
Loading