Placeholder for empty fields #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by E2E-Test |
Stezido
reviewed
Feb 14, 2020
There was a problem hiding this comment.
Good work.
Suggestions
- Create an own file called emptyStates where all empty states are saved. import it as emptyStates and get e.g. nodes with emptyStates.nodes or emptyStates.workflowitemList.
- Maybe you find a way to include images or icons/thumbnails in the empty states like material design suggests. (https://material.io/design/communication/empty-states.html#)
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
2 times, most recently
from
504976f
to
068b610
Compare
Stezido
reviewed
Feb 26, 2020
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
3 times, most recently
from
3a3ed8c
to
6d2e019
Compare
mathiashoeld
suggested changes
Mar 18, 2020
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
2 times, most recently
from
125ec1c
to
17f0082
Compare
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
from
456f768
to
a87d663
Compare
mathiashoeld
approved these changes
Apr 27, 2020
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
3 times, most recently
from
db6d016
to
5c41bd5
Compare
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
7 times, most recently
from
6539d3d
to
7b72b22
Compare
In tables and fields you can see images and small text messages when there is no data being fetched. Thus the users know why there is no data displayed. To make the code more efficient the function splitNodes splits the nodes for new organization request and existing organization requests. When reloading the page, no content is visible until data or empty state is fetched.
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
7 times, most recently
from
118b124
to
3076697
Compare
- After adding an image for a placeholder, the test couldn't find a button to click on anymore, so a force command solved the issue. - In timestamp_spec.js a div couldn't be found because it was nested, now the actual list is being forwarded. - Fixed project_analytics_spec.js and subproject_edit_spec.js,...
melissaSchmidt0302
force-pushed
the
placeholder-for-empty-fields
branch
from
3076697
to
646e4d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31