Add search for tags #416
Merged
Add search for tags #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by E2E-Test |
Stezido
force-pushed
the
add-search-for-tags
branch
from
286f828
to
6f472ae
Compare
Following prefixes are supported: -tag -name -status Without a prefix the properties tag, displayName and status are searched for hits Tag buttons support search on click Filter projects is executed by a web worker besides the UI-thread TODO: see added TODO in code remove filterProjects code or outsource the workers code
Modify/Move search feature related tests Rename project_tags file into project_tags_spec Add project update command to cypress
Stezido
force-pushed
the
add-search-for-tags
branch
from
eb1981b
to
61b6968
Compare
Add react-highlighter module Webworker additionally stores highlighing regex and search terms as array after calculating is finished
Rename projects created via login test Change assertion to should project no be visible to wait for debounce of search feature
Remove unnecessary should be visible calls in login e2e-test
Stezido
force-pushed
the
add-search-for-tags
branch
from
3c5b1eb
to
0693e43
Compare
Stezido
force-pushed
the
add-search-for-tags
branch
from
71f36f3
to
7c80b37
Compare
Update url (window.history.state) when searchTerm is changed Add convert methods (URL-searchTerm <-> barSearchTerm)
Otherwise the test fails in CI
Converting to URL query ignores multiple spaces Replace history state instead of push (disables funtionality of back button) Fix update the project list
mathiashoeld
suggested changes
Dec 20, 2019
1. Adjust Changelog 2. Delete unused filterProjects module 3. Move worker to common dir 4. Use color palette
mathiashoeld
approved these changes
Jan 7, 2020
daniel-arnauer
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Search for tags by adding prefixes is supported for "tag", "name" and "status" * Without a prefix the properties tag, displayName and status are searched for matches * Tag buttons support search on click * Filter projects is executed by a web worker to avoid blocking the UI-thread * Add debounce to searchinput to avoid re-rendering after every search input * Highlight displayname, status and tags on search match * Implement search via URL queries * E2e-tests are created * Adjust project search documentation * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The search feature only searches for the project name. It should be possible to search for tags too.
Follow up to #348
Implementation
The search feature should be extended, so that the user can search for every information a project holds. Additionally there should be a way to specifically search for special properties.
These properties shall be searched by putting prefixes in front of a searchTerm:
TODO
Closes #353
Closes #355
Closes #356
Closes #359
Closes #367