ui: New Search feature #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiashoeld
force-pushed
the
search-feature
branch
from
9f917c0
to
7a86890
Compare
Generated by E2E-Test |
|
TODO:
|
mathiashoeld
force-pushed
the
search-feature
branch
3 times, most recently
from
0ec7096
to
f1c4045
Compare
A new feature is added which lets the user filter the projects in the overview table. The search bar can be toggled by clicking the "Quick Search" icon. The text entered into the search bar is used to filter the projects that are visible to the user. The "Cancel" button in the search bar can be used to clear the text. The search bar is hidden (and reset) if a project details page is called. The user can hit the "Escape" key to close and reset the search bar. Add CHANGELOG entry and documentation for this new feature. Closes #347
When clicking on an item from the breadcrumbs navigation menu (top left), the search bar from the overview page is reset and no longer displayed.
Add 'data-test' information to tags in different components to prepare them for e2e-testing.
New e2e-tests are added for the navigation. The following elements are tested: - The hamburger menu on the left - The items of the left navigation card - The breadcrumb navigation - The right navigation items (including logout) - Filtering projects in the overview page
mathiashoeld
force-pushed
the
search-feature
branch
2 times, most recently
from
e5dadb2
to
c2f0df7
Compare
- Currencies: The format of the test has been changed to correctly fetch the created project to check for the currency symbol - Overview: Console log statement is removed and formatting
mathiashoeld
force-pushed
the
search-feature
branch
from
c2f0df7
to
d463f27
Compare
Stezido
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A new feature is added which lets the user filter the projects in the overview page.
The button "Quick Search" can be used to toggle the search bar. The term entered in the search bar is used for filtering the projects. When the user navigates to the project details page of a project or clicks on the breadcrumb menu "Main", the search field is cleared and the search bar is no longer displayed.
Closes #347
How to test
Go to the overview page, click the "Quick Search" button and enter a term to filter the projects in the overview page.