Remove env_example in frontend folder #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .gitignore files in the root directory and the frontend directory have been modified, so only the `.env` file in the root directory is ignored, but not the one in the frontend directory. Additionally: Remove .env_example file in frontend directory
Since the .env_example file does not exist anymore, we can just copy the whole content of the folder into the Docker container.
kevinbader
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.env_exampleis not needed and is removed. A.envfile is created that contains the line needed to display the version number of the frontend. The.gitignorefiles have been modified, so that the.envfile in the frontend directory is not ignored anymore.Closes #176
How to test
Start a deployment via Docker-compose - the Frontend version should be displayed in the UI.