Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When building the frontend docker, only the example env file is copied #176

Closed
jzakotnik opened this issue Apr 1, 2019 · 1 comment · Fixed by #244
Closed

When building the frontend docker, only the example env file is copied #176

jzakotnik opened this issue Apr 1, 2019 · 1 comment · Fixed by #244
Assignees
@mathiashoeld
Labels
good first issue Good for newcomers
Milestone
TruBudget 1.0.0

Comments

@jzakotnik
Copy link
Contributor

In the Dockerfile for the frontend, I think the .env file should be copied (if present) and the .env_example if there is none present, what do you think?
@gonzochic
Copy link
Collaborator

You are right. I believe we should rename the .env_example to .env because the user/developer don't need to adapt it anyways.

@gonzochic gonzochic added good first issue Good for newcomers low prio labels Apr 25, 2019
@gonzochic gonzochic added this to the TruBudget 1.0.0-beta.10 milestone Apr 25, 2019
@mathiashoeld mathiashoeld mentioned this issue Apr 26, 2019
Merged
@mathiashoeld mathiashoeld self-assigned this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathiashoeld mathiashoeld

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
TruBudget 1.0.0
Development

Successfully merging a pull request may close this issue.

Remove env_example in frontend folder openkfw/TruBudget
3 participants
@jzakotnik @gonzochic @mathiashoeld