bundle identifier fix (rfc1034 to allow spaces in names) #7597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dimitre does As the other will will have different values for Debug and Release. |
Member
Author
|
My bad, that was the intention. I'll update this PR now |
Member
Author
|
Yes it works well, I've pushed the update. Generated a project called "space sketch" and compiled. inspecting inside .app I've noticed the Info.plist have well formed data now: <string>cc.openFrameworks.space-sketch</string> |
Member
|
looks good to me ( as long as it passes macOS checks ) |
danoli3
added a commit
to danoli3/openFrameworks
that referenced
this pull request
Aug 21, 2023
…fixes * commit '11cdc79a94d3a795020ca7a26b082b95e5989a29': macOS GLFW - no shadow when fullscreen (openframeworks#7605) initGrabber -> setup (openframeworks#7604) Emscripten player update (openframeworks#7561) Improve ofGetEnv with default value. (openframeworks#7587) fix: ofLogError message typo (openframeworks#7599) Osc swap (openframeworks#7600) ofParameter: reinit mechanism: use setMethod() instead of set() (openframeworks#7564) add of.entitlements to Examples/.gitignore (openframeworks#7583) bundle identifier fix (rfc1034 to allow spaces in names) (openframeworks#7597) WIP - more .h cleanup (openframeworks#7596) update pg submodule PG v.17 (openframeworks#7580) bugfix random_shuffle is removed in C++17 - replace with std::shuffle (openframeworks#7575) add setup argument to listen on specific ip (openframeworks#7574) Ubuntu : add make to packages to install (openframeworks#7571) projectGenerator update (openframeworks#7567) loadModel -> load (openframeworks#7566) # Conflicts: # libs/openFrameworks/utils/ofXml.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more info here:
closes openframeworks/projectGenerator#403