This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fixed blooms dir creation#8941
Merged
Merged
Conversation
svyatonik
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
tomusdrw
approved these changes
Jun 21, 2018
debris
approved these changes
Jun 22, 2018
dvdplm
added a commit
that referenced
this pull request
Jun 22, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 27, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: deps: bump fs-swap (openethereum#8953) Eliminate some more `transmute()` (openethereum#8879) Restrict vault.json permssion to owner and using random suffix for temp vault.json file (openethereum#8932) print SS.self_public when starting SS node (openethereum#8949) scripts: minor improvements (openethereum#8930) rpc: cap gas limit of local calls (openethereum#8943) docs: update changelogs (openethereum#8931) ethcore: fix compilation when using slow-blocks or evm-debug features (openethereum#8936) fixed blooms dir creation (openethereum#8941) Update hardcoded headers (openethereum#8925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@debris I've just replaced
create_dirwithcreate_dir_all, but could you please check that thebloomspath is what you've expected. On my Ubuntu machine it is/home/svyatonik/.local/share/io.parity.ethereum/chains/DevelopmentChain/db/1484bce8c021f2ca/overlayrecent/db/blooms. I haven't reviewed the blooms PR, so not sure - if this is correct.@Tbaut Sorry - had a yesterday's morning master without this PR merged in :) This PR should fix the issue