This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Restrict vault.json permssion to owner and using random suffix for temp vault.json file#8932
Merged
Merged
Conversation
sorpaas
added
A0-pleasereview 🤓
svyatonik
approved these changes
Jun 22, 2018
Contributor
|
Needs a 2nd review. |
andresilva
approved these changes
Jun 22, 2018
5chdn
added
A8-looksgood 🦄
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jun 27, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: deps: bump fs-swap (openethereum#8953) Eliminate some more `transmute()` (openethereum#8879) Restrict vault.json permssion to owner and using random suffix for temp vault.json file (openethereum#8932) print SS.self_public when starting SS node (openethereum#8949) scripts: minor improvements (openethereum#8930) rpc: cap gas limit of local calls (openethereum#8943) docs: update changelogs (openethereum#8931) ethcore: fix compilation when using slow-blocks or evm-debug features (openethereum#8936) fixed blooms dir creation (openethereum#8941) Update hardcoded headers (openethereum#8925)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an unlucky situation, multiple process (which may be incorrectly started to run on the same chain) can decide to write to
vault_temp.jsonfile at the same time, resulting in a corrupted file. We don't protect this in key files right now, but given the original intention to write tovault_temp.jsonand then atomically rename tovault.jsonis to prevent similar type of thing, I think it would work better to use a random suffix ifvault_temp.jsonfile already exists.This also restricts newly created
vault.jsonfile with permission owner only.