This repository was archived by the owner on Nov 6, 2020. It is now read-only.
rename inject to drain_transaction_overlay#11657
Merged
Merged
Conversation
ordian
added
A0-pleasereview 🤓
dvdplm
approved these changes
Apr 27, 2020
Collaborator
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
So the only place where we called inject() was the state rebuilder (and tests)? This code disables the ability to sneak in extra DB ops which I think is a good thing. I also like the naming here
vorot93
approved these changes
Apr 27, 2020
|
Needs a rebase on master - David's PR has already been merged hence the conflict. |
vorot93
added
A7-looksgoodcantmerge 🙄
ordian
added
A8-looksgood 🦄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a step towards #11656.