This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Add git binary to first docker stage for generating proper log headers#11651
Merged
Conversation
…t also on the git binary for generating COMMIT DATE and SHA reference used by the openethereum binary to display in the log. This commit tries to solve it in the alpine docker image
girianshido
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR https://github.com/openethereum/openethereum/pull/11608 seems to not be enough.
Checking the vergen library repo https://github.com/rustyhorde/vergen#note-on-semver found that it relies on the git binary to extract the values of .git folder
This should solve the UNKNOWN values on the log header