This repository was archived by the owner on Nov 6, 2020. It is now read-only.
license update#11543
Merged
Merged
Conversation
ordian
commented
Mar 4, 2020
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Open Ethereum. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
Member
Author
There was a problem hiding this comment.
how come this file missing a license header? :)
Collaborator
There was a problem hiding this comment.
It is probably my fault when I refactored to use ethereum-types in RPC and forgot to add the license header apparentely.
ordian
added
A0-pleasereview 🤓
Merged
dvdplm
approved these changes
Mar 5, 2020
niklasad1
reviewed
Mar 5, 2020
Collaborator
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
The license header in util/EIP-152/src/portable.rs is not updated, can you fix it?
Otherwise looks good.
Member
Author
Good catch! Somehow the script didn't fix it. |
Collaborator
The script is hacky :) I wrote it but assumes a new line after the license header which |
niklasad1
approved these changes
Mar 5, 2020
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
ordian
added a commit
that referenced
this pull request
Mar 10, 2020
* master: Code cleanup in the sync module (#11552) initial cleanup (#11542) Warn if genesis constructor revert (#11550) ethcore: cleanup after #11531 (#11546) license update (#11543) Less cloning when importing blocks (#11531) Github Actions (#11528) Fix Alpine Dockerfile (#11538) Remove AuxiliaryData/AuxiliaryRequest (#11533) [journaldb]: cleanup (#11534) Remove references to parity-ethereum (#11525) Drop IPFS support (#11532) chain-supplier: fix warning reporting for GetNodeData request (#11530) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #11542