Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Remove references to parity-ethereum#11525

Merged
dvdplm merged 3 commits into
masterfrom
mp-de-parityify
Mar 1, 2020
Merged

Remove references to parity-ethereum#11525
dvdplm merged 3 commits into
masterfrom
mp-de-parityify

Conversation

@s3krit
Copy link
Copy Markdown
Contributor

@s3krit s3krit commented Feb 26, 2020

This is a general PR to remove/replace instances of Parity-Ethereum from the project. For starters, I have just changed the links in the CHANGELOGs and README.md to reflect the new home for this project. Moving forwards, we'd also want to change references to things like blogs, wiki pages, etc. but perhaps that can happen as the Open Ethereum community makes decisions on what we want to implement.

@s3krit s3krit added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M3-docs 📑 Documentation. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 26, 2020
@dvdplm dvdplm requested a review from vorot93 February 26, 2020 17:25
find . -type f -exec sed -i 's_paritytech/parity-ethereum_OpenEthereum/open-ethereum_g' {} \;
@ordian
Copy link
Copy Markdown
Member

ordian commented Feb 27, 2020

other references to be renamed

ethcore/types/src/errors/mod.rs
17://! General error types for use in parity-ethereum.
ethcore/trace/src/types/trace.rs
150:/// the older encodings used in parity-ethereum versions < 2.7 and 2.7.0.
util/network-devp2p/src/discovery.rs
587:							trace!(target: "discovery", "Got Pong from an old parity-ethereum version.");
scripts/docker/README.md
10:cd parity-ethereum
ethash/src/compute.rs
267:			compile_error!("parity-ethereum currently only supports little-endian targets");

Do we want to rename the binary name as well?

@vorot93
Copy link
Copy Markdown

vorot93 commented Feb 27, 2020

@ordian we do

@ordian
Copy link
Copy Markdown
Member

ordian commented Feb 27, 2020

Do we want to rename the binary name as well?

I meant in this PR or in another? This renaming might break a few things like our current CI for example.

@ordian ordian mentioned this pull request Feb 28, 2020
4 tasks
@vorot93
Copy link
Copy Markdown

vorot93 commented Feb 29, 2020

@ordian I suppose we could do it after GH actions is merged then.

@dvdplm dvdplm merged commit 62b73a6 into master Mar 1, 2020
@niklasad1 niklasad1 deleted the mp-de-parityify branch March 2, 2020 08:34
dvdplm added a commit that referenced this pull request Mar 3, 2020
* master:
  Remove AuxiliaryData/AuxiliaryRequest (#11533)
  [journaldb]: cleanup (#11534)
  Remove references to parity-ethereum (#11525)
  Drop IPFS support (#11532)
@ordian ordian mentioned this pull request Mar 4, 2020
ordian added a commit that referenced this pull request Mar 6, 2020
* master:
  Remove references to parity-ethereum (#11525)
  Drop IPFS support (#11532)
  chain-supplier: fix warning reporting for GetNodeData request (#11530)
ordian added a commit that referenced this pull request Mar 10, 2020
* master:
  Code cleanup in the sync module (#11552)
  initial cleanup (#11542)
  Warn if genesis constructor revert (#11550)
  ethcore: cleanup after #11531 (#11546)
  license update (#11543)
  Less cloning when importing blocks (#11531)
  Github Actions (#11528)
  Fix Alpine Dockerfile (#11538)
  Remove AuxiliaryData/AuxiliaryRequest (#11533)
  [journaldb]: cleanup (#11534)
  Remove references to parity-ethereum (#11525)
  Drop IPFS support (#11532)
  chain-supplier: fix warning reporting for GetNodeData request (#11530)
  Faster kill_garbage (#11514)
  [EngineSigner]: don't sign message with only zeroes (#11524)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M3-docs 📑 Documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants