This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Update ProgPoW to 0.9.3#11407
Merged
Merged
Conversation
0.9.2 version is deprecated due to efficiency
|
It looks like @ethcoreorg signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ordian
approved these changes
Jan 24, 2020
ordian
added
A8-looksgood 🦄
Contributor
|
@ethcoreorg how did you update the values for the test vectors? Did you confirm we're getting the same results as other implementations? |
Contributor
Author
|
@andresilva Why not sure https://github.com/ethereum/EIPs/blob/master/assets/eip-1057/test-vectors-0.9.3.json, it has already been published on EIPs |
Contributor
Author
|
I've also confirmed that the test vector works for go-ethereum implementation also holiman/go-ethereum#4 |
Contributor
|
@ethcoreorg I saw the EIP link you posted and checked the changes in constants but didn't notice the test vectors. Thanks! :) |
ordian
added
the
B0-patch-stable 🕷
s3krit
pushed a commit
that referenced
this pull request
Jan 27, 2020
0.9.2 version is deprecated due to efficiency
dvdplm
added a commit
that referenced
this pull request
Jan 29, 2020
…pstream * master: Add POSDAO transition and malice report queue. (#11245) update master/nightly version: v2.8.0 (#11419) ethcore/res: remove morden testnet (#11392) fix: export hardcoded sync format (#11416) update hardcoded headers: mainnet and ropsten (#11414) AuthorityEngine: Minor cleanups. (#11408) Update POA bootnodes (#11411) Add EtherCore support (#11402) verification: fix race same block + misc (#11400) Update ProgPoW to 0.9.3 (#11407) update classic testnet bootnodes (#11398) dependencies: bump `derive_more v0.99` (#11405) engine error: remove faulty/unused `From` (#11404) Switching to stable-track (#11377) ethcore/res: fix ethereum classic chainspec blake2_f activation block num (#11391) Update copyright notice 2020 (#11386)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.9.2 version is deprecated due to efficiency
See 0.9.3 specification on https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1057.md#specification