Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

ethcore/res: fix ethereum classic chainspec blake2_f activation block…#11391

Merged
sorpaas merged 1 commit into
openethereum:masterfrom
q9f:q9-fix-chainspec
Jan 20, 2020
Merged

ethcore/res: fix ethereum classic chainspec blake2_f activation block…#11391
sorpaas merged 1 commit into
openethereum:masterfrom
q9f:q9-fix-chainspec

Conversation

@q9f
Copy link
Copy Markdown
Member

@q9f q9f commented Jan 20, 2020

Accidentally introduced in #11347

Block number was copy-pasted from the Kotti chainspec. /cc @sorpaas

Correct block numbers can be compared against: https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1061.md#abstract

This needs a timely chain-spec release if possible.

  • You added a brief description of the PR, e.g.:
    • What does it do?
    • What important points reviewers should know?
    • Is there something left for follow-up PRs?
  • You labeled the PR with appropriate labels if you have permissions to do so.
  • You mentioned a related issue if this PR related to it, e.g. Fixes #228 or Related #1337.
  • You asked any particular reviewers to review. If you aren't sure, start with GH suggestions.
  • Your PR adheres the style guide
    • In particular, mind the maximal line length.
    • There is no commented code checked in unless necessary.
    • Any panickers have a proof or removed.
  • You updated any rustdocs which may have changed

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Jan 20, 2020

It looks like @q9f hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@q9f q9f requested review from dvdplm, jam10o-new and sorpaas January 20, 2020 09:59
@q9f
Copy link
Copy Markdown
Member Author

q9f commented Jan 20, 2020

[clabot:check]

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Jan 20, 2020

It looks like @q9f signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@q9f q9f mentioned this pull request Jan 20, 2020
Merged
ordian
ordian approved these changes Jan 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations. labels Jan 20, 2020
@sorpaas sorpaas merged commit 171526c into openethereum:master Jan 20, 2020
@ordian ordian added the B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. label Jan 20, 2020
@q9f q9f deleted the q9-fix-chainspec branch January 20, 2020 18:02
@soc1c
Copy link
Copy Markdown
Contributor

soc1c commented Jan 23, 2020

can we get a beta and stable chain-spec release with #11347 and #11391? testnets fork in two weeks. thanks 🙏

s3krit pushed a commit that referenced this pull request Jan 24, 2020
@q9f @s3krit
ethcore/res: fix ethereum classic chainspec blake2_f activation block…
c253e1f 
… num (#11391)
dvdplm added a commit that referenced this pull request Jan 29, 2020
@dvdplm
Merge branch 'master' into dp/chore/use-latest-attempt-to-switch-to-u…
c3a4fa7 
…pstream

* master:
  Add POSDAO transition and malice report queue. (#11245)
  update master/nightly version: v2.8.0 (#11419)
  ethcore/res: remove morden testnet (#11392)
  fix: export hardcoded sync format (#11416)
  update hardcoded headers: mainnet and ropsten (#11414)
  AuthorityEngine: Minor cleanups. (#11408)
  Update POA bootnodes (#11411)
  Add EtherCore support (#11402)
  verification: fix race same block + misc (#11400)
  Update ProgPoW to 0.9.3 (#11407)
  update classic testnet bootnodes (#11398)
  dependencies: bump `derive_more v0.99` (#11405)
  engine error: remove faulty/unused `From` (#11404)
  Switching to stable-track (#11377)
  ethcore/res: fix ethereum classic chainspec blake2_f activation block num (#11391)
  Update copyright notice 2020 (#11386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvdplm dvdplm Awaiting requested review from dvdplm

@sorpaas sorpaas Awaiting requested review from sorpaas

2 more reviewers

@ordian ordian ordian approved these changes

@jam10o-new jam10o-new jam10o-new approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M2-config 📂 Chain specifications and node configurations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@q9f @parity-cla-bot @soc1c @ordian @jam10o-new @sorpaas