This repository was archived by the owner on Nov 6, 2020. It is now read-only.
[ethcore]: cleanup dependencies#11043
Merged
Merged
Conversation
niklasad1
added
A0-pleasereview 🤓
niklasad1
commented
Sep 12, 2019
| //! Ethcore library | ||
| //! | ||
| //! ### Rust version: | ||
| //! - nightly |
Collaborator
Author
There was a problem hiding this comment.
removed these docs because those are outdated
niklasad1
force-pushed
the
na-ethcore-dependency-cleanup
branch
from
29d400a to
560318f
Compare
ordian
approved these changes
Sep 12, 2019
ordian
added
A8-looksgood 🦄
dvdplm
approved these changes
Sep 12, 2019
Collaborator
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Thank you for taking care of this, it was on my list. I was convinced account-db was needed by some combo of features but apparently I was wrong.
dvdplm
added a commit
that referenced
this pull request
Sep 13, 2019
* master: (70 commits) ethcore: remove `test-helper feat` from build (#11047) Include test-helpers from ethjson (#11045) [ethcore]: cleanup dependencies (#11043) add more tx tests (#11038) Fix parallel transactions race-condition (#10995) [ethcore]: make it compile without `test-helpers` feature (#11036) Benchmarks for block verification (#11035) Move snapshot related traits to their proper place (#11012) cleanup json crate (#11027) [spec] add istanbul test spec (#11033) [json-spec] make blake2 pricing spec more readable (#11034) Add blake2_f precompile (#11017) Add new line after writing block to hex file. (#10984) fix: remove unused error-chain (#11028) fix: remove needless use of itertools (#11029) Convert `std::test` benchmarks to use Criterion (#10999) Fix block detail updating (#11015) [trace] introduce trace failed to Ext (#11019) cli: update usage and version headers (#10924) [private-tx] remove unused rand (#11024) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.