This repository was archived by the owner on Nov 6, 2020. It is now read-only.
[ethcore]: make it compile without test-helpers feature#11036
Merged
Conversation
Used by `ethcore/client/client` when importing blocks
niklasad1
added
A0-pleasereview 🤓
niklasad1
force-pushed
the
na-fix-ethcore-compile
branch
from
6feb700 to
75d0e37
Compare
dvdplm
approved these changes
Sep 11, 2019
Collaborator
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
A part from question about rustc-hex, it lgtm.
ordian
added
A6-mustntgrumble 💦
niklasad1
force-pushed
the
na-fix-ethcore-compile
branch
from
b2053f7 to
4be7809
Compare
niklasad1
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Sep 13, 2019
* master: (70 commits) ethcore: remove `test-helper feat` from build (#11047) Include test-helpers from ethjson (#11045) [ethcore]: cleanup dependencies (#11043) add more tx tests (#11038) Fix parallel transactions race-condition (#10995) [ethcore]: make it compile without `test-helpers` feature (#11036) Benchmarks for block verification (#11035) Move snapshot related traits to their proper place (#11012) cleanup json crate (#11027) [spec] add istanbul test spec (#11033) [json-spec] make blake2 pricing spec more readable (#11034) Add blake2_f precompile (#11017) Add new line after writing block to hex file. (#10984) fix: remove unused error-chain (#11028) fix: remove needless use of itertools (#11029) Convert `std::test` benchmarks to use Criterion (#10999) Fix block detail updating (#11015) [trace] introduce trace failed to Ext (#11019) cli: update usage and version headers (#10924) [private-tx] remove unused rand (#11024) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change
rustc-hexis not an optional dependency anymore which this PR fixesAs a bonus, I added docs to DataFormat and replaced space indentation.