Allow default block parameter to be blockHash by seunlanlege · Pull Request #10932 · openethereum/parity-ethereum

seunlanlege · 2019-08-01T11:51:39Z

Adds support for deserializing blockHash and blockNumber as per EIP-1898 to BlockNumber

Closes #10567

parity-cla-bot · 2019-08-01T11:51:41Z

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ordian

LGTM. (requireCanonical is lacking for a full EIP-1898 support)

ordian · 2019-08-05T15:41:42Z

-		let s = r#""10""#;
-		assert!(serde_json::from_str::<BlockNumber>(s).is_err());
+	fn should_not_deserialize() {
+		let s = r#"[{}, "10"]"#;


Do we reject requireCanonical with BlockNumber or any other invalid combinations?

Currently, the code does not reject if used with blockNumber instead it is ignored. Do you think we should reject?

I think if we derive Serialize/Deserialize (seems possible with serde attributes) instead of manually implementing it, it would be automatically supported. This can be done in a separate PR though.

* master: Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941)

* master: journaldb changes (#10929) Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941) Updated security@parity.io key (#10939) Change the return type of step_inner function. (#10940) get rid of hidden mutability of Spec (#10904) simplify BlockReward::reward implementation (#10906) Kaspersky AV whitelisting (#10919) additional arithmetic EVM opcode benchmarks (#10916) [Cargo.lock] cargo update -p crossbeam-epoch (#10921) Fixes incorrect comment. (#10913) Add file path to disk map write/read warnings (#10911)

afck · 2019-08-09T07:43:41Z

 			.expect("code will return Some if given BlockId::Latest; qed")
 	}

+	fn chain(&self) -> Arc<BlockProvider>;


That triggered another compiler warning for me:

warning: missing documentation for a trait method --> ethcore/src/client/traits.rs:236:2 | 236 | fn chain(&self) -> Arc<BlockProvider>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: lint level defined here --> ethcore/src/lib.rs:17:9 | 17 | #![warn(missing_docs, unused_extern_crates)]

Yeah, missed this during review. I added docs in another PR so it'll sort itself out soon enough.

* master: [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926) Extract Machine from ethcore (#10949) removed redundant state_root function from spec, improve spec error types (#10955) Add support for Energy Web Foundation's new chains (#10957) [evmbin] add more tests to main.rs (#10956) Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953) unify loading spec && further spec cleanups (#10948) refactor: Refactor evmbin CLI (#10742) journaldb changes (#10929) Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941) Updated security@parity.io key (#10939) Change the return type of step_inner function. (#10940)

* allow default block parameter to be blockHash * requireCanonical * block check takes precedence over canon check

fabioberger · 2019-11-25T13:47:01Z

It's been nearly 4 months since this got merged. When is it going to be released? Geth support is already out.

dvdplm · 2019-11-25T13:53:30Z

Is it not in the latest beta?

niklasad1 · 2019-11-25T14:40:29Z

@fabioberger @dvdplm It is included in v2.6.5 beta

EDIT: I forgot to add it in the PR description and thus it's missing in the CHANGELOG.

fabioberger · 2019-11-25T18:50:30Z

Thanks @niklasad1! 🙏 Any estimates on when it'll make it into the stable releases?

fabioberger · 2019-12-19T17:07:03Z

@dvdplm any idea when this will make it into a stable release? I've seen several stable releases go out but none include these changes.

niklasad1 · 2019-12-19T17:21:16Z

@fabioberger

Sorry late answer, I expect it to be included in stable 2.6.x

fabioberger · 2020-01-29T11:32:39Z

Thanks for the reply @niklasad1. Any idea when stable 2.6.x will be released? I've been waiting for ~2 months for this to be released so I rely on it in production.

niklasad1 · 2020-01-29T11:55:25Z

@fabioberger It will be included stable 2.7, I expect it to be released soon.

EDIT: It is released, https://github.com/paritytech/parity-ethereum/releases/tag/v2.7.0

riptl · 2020-10-02T18:42:37Z

Since this is not part of OpenEthereum 3.1 history anymore, I backported this in openethereum/openethereum#70

allow default block parameter to be blockHash

8a4ced5

seunlanlege added the M6-rpcapi 📣 RPC API. label Aug 1, 2019

ordian added the A8-looksgood 🦄 Pull request is reviewed well. label Aug 1, 2019

ordian added this to the 2.7 milestone Aug 1, 2019

ordian approved these changes Aug 1, 2019

View reviewed changes

dvdplm approved these changes Aug 5, 2019

View reviewed changes

seunlanlege added 2 commits August 5, 2019 16:30

requireCanonical

ef2367f

block check takes precedence over canon check

c2d29c2

ordian reviewed Aug 5, 2019

View reviewed changes

dvdplm merged commit 7227985 into master Aug 6, 2019

dvdplm added a commit that referenced this pull request Aug 6, 2019

Merge branch 'master' into dp/chore/move-machine-to-own-crate

51ba2f4

* master: Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941)

afck reviewed Aug 9, 2019

View reviewed changes

niklasad1 deleted the EIP-1898 branch September 13, 2019 13:19

dvdplm added the B1-patch-beta 🕷🕷 label Nov 8, 2019

niklasad1 pushed a commit that referenced this pull request Nov 8, 2019

Allow default block parameter to be blockHash (#10932)

71bc094

* allow default block parameter to be blockHash * requireCanonical * block check takes precedence over canon check

charles-cooper mentioned this pull request Nov 19, 2019

Update eip-1898.md ethereum/EIPs#2382

Merged

soc1c mentioned this pull request Nov 25, 2019

v2.6.5 beta #11240

Merged

35 tasks

This was referenced Oct 2, 2020

[DELETE THIS] EIP-1898 #11884

Closed

EIP-1898: Allow default block parameter to be blockHash openethereum/openethereum#70

Closed

rakita mentioned this pull request Dec 28, 2020

EIP-1898: Allow default block parameter to be blockHash openethereum/openethereum#203

Merged

Conversation

seunlanlege commented Aug 1, 2019

Uh oh!

parity-cla-bot commented Aug 1, 2019

Uh oh!

ordian left a comment

Choose a reason for hiding this comment

Uh oh!

ordian Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

seunlanlege Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

ordian Aug 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afck Aug 9, 2019

Choose a reason for hiding this comment

Uh oh!

dvdplm Aug 9, 2019

Choose a reason for hiding this comment

Uh oh!

fabioberger commented Nov 25, 2019

Uh oh!

dvdplm commented Nov 25, 2019

Uh oh!

niklasad1 commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabioberger commented Nov 25, 2019

Uh oh!

fabioberger commented Dec 19, 2019

Uh oh!

niklasad1 commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabioberger commented Jan 29, 2020

Uh oh!

niklasad1 commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

riptl commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ordian Aug 6, 2019 •

edited

Loading

niklasad1 commented Nov 25, 2019 •

edited

Loading

niklasad1 commented Dec 19, 2019 •

edited

Loading

niklasad1 commented Jan 29, 2020 •

edited

Loading