Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

ci: publish docs debug #10638

Merged
gabreal merged 1 commit into from
May 8, 2019
Merged

ci: publish docs debug #10638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,3 +289,4 @@ publish-docs:
- scripts/gitlab/publish-docs.sh
tags:
- linux-docker
allow_failure: true
7 changes: 5 additions & 2 deletions scripts/gitlab/publish-docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,11 @@ commit_files() {

upload_files() {
echo "__________Upload files__________"
git push -q origin HEAD
git push -q -f --tags
# this version of git (2.7.4) will dump the token on failure
Copy link
Copy Markdown
Collaborator

@kirushik kirushik May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even use token instead of a deploy SSH key?

git push -q origin HEAD 2>&1 \
| sed -r "s|(${GITHUB_USER}):[a-f0-9]+@|\1:REDACTED@|g"
Copy link
Copy Markdown
Collaborator

@kirushik kirushik May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it possible that git will change the failure format and this regexp will stop redacting the secret...
And this failure will be terribly hard to notice in advance...

Copy link
Copy Markdown
Contributor Author

@gabreal gabreal May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the most simple pattern username:token

git push -q -f --tags 2>&1 \
| sed -r "s|(${GITHUB_USER}):[a-f0-9]+@|\1:REDACTED@|g"
}

RPC_TRAITS_DIR="rpc/src/v1/traits"
Expand Down