This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Merge Machine and WithBalances#10071
Merged
Merged
Conversation
tomaka
added
A0-pleasereview 🤓
ascjones
approved these changes
Dec 18, 2018
Contributor
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Looks good, but the title says WithRewards and the changes are actually merging WithBalances. Any reason not to do the same for WithRewards?
Contributor
Author
|
Not everything requires the |
ascjones
added
A8-looksgood 🦄
ascjones
added
A7-looksgoodcantmerge 🙄
5chdn
added
A8-looksgood 🦄
5chdn
approved these changes
Jan 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up some code.
Doesn't change any logic.