Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Merge Machine and WithRewards and make Machine an associated type of Engine #10068

Closed
tomaka wants to merge 2 commits into
openethereum:masterfrom
tomaka:insubstantial-rework
Closed

Merge Machine and WithRewards and make Machine an associated type of Engine #10068
tomaka wants to merge 2 commits into
openethereum:masterfrom
tomaka:insubstantial-rework

Conversation

@tomaka
Copy link
Copy Markdown
Contributor

@tomaka tomaka commented Dec 14, 2018

Cleaning up some code.
Doesn't change any logic.

@tomaka tomaka added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 14, 2018
@tomaka
Copy link
Copy Markdown
Contributor Author

tomaka commented Dec 14, 2018

Oh, I didn't realize that my change requires a newer version of Rust.

@tomaka
Copy link
Copy Markdown
Contributor Author

tomaka commented Dec 15, 2018

Replaced with #10071

@tomaka tomaka closed this Dec 15, 2018
@tomaka tomaka deleted the insubstantial-rework branch December 15, 2018 13:42
@5chdn 5chdn added this to the 2.3 milestone Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants