Skip to content

Conversation

@pberginkonsult
Copy link
Contributor

A couple of improvements to the linuxptp recipe. We use the install function from the makefile in order to install all produced binaries and manual pages. Also ship and package example configurations in a separate package. Inspiration is taken from how debian package linuxptp.

Before this patch just a few of the produced binaries were installed.
This patch use install from linuxptp's makefile to install all binaries
and man pages. man pages are packaged in linuxptp-doc.

Signed-off-by: Peter Bergin <[email protected]>
Signed-off-by: Peter Bergin <[email protected]>

# Install example configs from source tree
install -d ${D}${docdir}/${PN}
cp -r ${S}/configs ${D}${docdir}/${PN}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if using something like below should be used

cp -R --no-dereference --preserve=mode,links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked in oe-core and meta-openembedded and can not find a common pattern around this. But agree that your suggestion is better if in the future links show up among the installed files.

configs directory from source is shipped in linuxptp-configs package
and includes some example configuration files for the applications.

Signed-off-by: Peter Bergin <[email protected]>
@kraj
Copy link
Contributor

kraj commented Jun 9, 2021

thanks I have staged it in master-next

Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kraj
Copy link
Contributor

kraj commented Jun 16, 2021

this is in master now.

@kraj kraj closed this Jun 16, 2021
halstead pushed a commit that referenced this pull request Jan 8, 2023
It fixes CVE-2022-45062 in xfce4-settings 4.16.5.

CVE: CVE-2022-45062

$ git log --oneline xfce4-settings-4.16.2..xfce4-settings-4.16.5 |  grep -v "Update translation"

83ea11cf Updates for release
f1cb5bda mime-settings: Properly quote command parameters
f7707d8b Revert "Escape characters which do not belong into an URI/URL
(Issue #390)"
b532324f Back to development
b9729c85 Updates for release
55e3c5fb Escape characters which do not belong into an URI/URL (Issue #390)
341443f8 Prefer full command when basic command is env (Fixes #358)
8d4106b3 Back to development
024399b1 Updates for release
af601e32 build: Fix intltool lock file problem during make distcheck
0875cfba xfsettingsd: Fix recursive lock in libX11 (Fixes #369)
20d866dc Back to developmen

Signed-off-by: Archana Polampalli <[email protected]>
[  alt summary

4.16.5 (2022-11-12)
======
- mime-settings: Properly quote command parameters
- Revert "Escape characters which do not belong into an URI/URL (Issue

4.16.4 (2022-11-07)
======
- Escape characters which do not belong into an URI/URL (Issue #390)
- Prefer full command when basic command is env (Fixes #358)
- Translation Updates:
  Japanese, Portuguese, Russian

4.16.3
 ======
- xfsettingsd: Fix recursive lock in libX11 (Fixes #369)
- build: Fix intltool lock file problem during make distcheck
- Translation Updates:
  Armenian (Armenia), Belarusian, Catalan, English (Canada), English
  (United Kingdom), Estonian, Galician, Greek, Indonesian, Kazakh,
  Korean, Lithuanian, Malay, Occitan (post 1500), Polish, Romanian,
  Swedish
]
Signed-off-by: Kai Kang <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this pull request Jan 20, 2023
Source: meta-openembedded
MR: 123754
Type: Integration
Disposition: Merged from meta-openembedded
ChangeID: 8568104
Description:

It fixes CVE-2022-45062 in xfce4-settings 4.16.5.

CVE: CVE-2022-45062

$ git log --oneline xfce4-settings-4.16.2..xfce4-settings-4.16.5 |  grep -v "Update translation"

83ea11cf Updates for release
f1cb5bda mime-settings: Properly quote command parameters
f7707d8b Revert "Escape characters which do not belong into an URI/URL
(Issue openembedded#390)"
b532324f Back to development
b9729c85 Updates for release
55e3c5fb Escape characters which do not belong into an URI/URL (Issue openembedded#390)
341443f8 Prefer full command when basic command is env (Fixes openembedded#358)
8d4106b3 Back to development
024399b1 Updates for release
af601e32 build: Fix intltool lock file problem during make distcheck
0875cfba xfsettingsd: Fix recursive lock in libX11 (Fixes openembedded#369)
20d866dc Back to developmen

Signed-off-by: Archana Polampalli <[email protected]>
[  alt summary

4.16.5 (2022-11-12)
======
- mime-settings: Properly quote command parameters
- Revert "Escape characters which do not belong into an URI/URL (Issue

4.16.4 (2022-11-07)
======
- Escape characters which do not belong into an URI/URL (Issue openembedded#390)
- Prefer full command when basic command is env (Fixes openembedded#358)
- Translation Updates:
  Japanese, Portuguese, Russian

4.16.3
 ======
- xfsettingsd: Fix recursive lock in libX11 (Fixes openembedded#369)
- build: Fix intltool lock file problem during make distcheck
- Translation Updates:
  Armenian (Armenia), Belarusian, Catalan, English (Canada), English
  (United Kingdom), Estonian, Galician, Greek, Indonesian, Kazakh,
  Korean, Lithuanian, Malay, Occitan (post 1500), Polish, Romanian,
  Swedish
]
Signed-off-by: Kai Kang <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
Signed-off-by: Jeremy A. Puhlman <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Feb 16, 2023
0002-iscsiuio-Use-pthread_t-for-INVALID_THREAD.patch
removed since it's included in 2.1.8.

0001-Makefile-Do-not-set-Werror.patch
refreshed for 2.1.8

Changelog:
===========
 make: avoid hard-coding path to sed (openembedded#357)
 etc: install system unit with without executable bit (openembedded#354)
 Add ability for MGMT IPC to check UID only
 Use config for iscsistart and iscsiadm fw login
 iscsiuio: Use pthread_t for INVALID_THREAD (openembedded#363)
 Add a 'distclean' Makefile top-level target
 Cleanup fwparam makefile (openembedded#360)
 Small bug fixes (openembedded#364)
 Use meson as the main build system (openembedded#365)
 libopeniscsiusr: cleanup recent reallocarray->realloc change (openembedded#369)
 Added examples in man file for iscsiadm session commands.
 iscsid: fix logout pdu send failure handling
 Update README's error handler/timeout section
 iscsiuio: fix LDADD
 libopeniscsiusr: use realloc instead of reallocarray (openembedded#368)
 iscsiadm: enable specify iface name-value parameters when creating iface
 Fix a possible passing null pointer in usr/iface.c (openembedded#356)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Feb 17, 2023
0002-iscsiuio-Use-pthread_t-for-INVALID_THREAD.patch
removed since it's included in 2.1.8.

0001-Makefile-Do-not-set-Werror.patch
refreshed for 2.1.8

Changelog:
===========
 make: avoid hard-coding path to sed (openembedded#357)
 etc: install system unit with without executable bit (openembedded#354)
 Add ability for MGMT IPC to check UID only
 Use config for iscsistart and iscsiadm fw login
 iscsiuio: Use pthread_t for INVALID_THREAD (openembedded#363)
 Add a 'distclean' Makefile top-level target
 Cleanup fwparam makefile (openembedded#360)
 Small bug fixes (openembedded#364)
 Use meson as the main build system (openembedded#365)
 libopeniscsiusr: cleanup recent reallocarray->realloc change (openembedded#369)
 Added examples in man file for iscsiadm session commands.
 iscsid: fix logout pdu send failure handling
 Update README's error handler/timeout section
 iscsiuio: fix LDADD
 libopeniscsiusr: use realloc instead of reallocarray (openembedded#368)
 iscsiadm: enable specify iface name-value parameters when creating iface
 Fix a possible passing null pointer in usr/iface.c (openembedded#356)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
halstead pushed a commit that referenced this pull request Apr 29, 2023
…325338b6e7b3d42de)

Drop patches now part of new upstream release:
- 0001-Fix-memory-leak.patch
- 0001-cmake-Link-with-libatomic-on-rv32-rv64.patch
- 0001-dlt-system-Fix-buffer-overflow-detection-on-32bit-ta.patch

Cherry-pick and propose upstream two patches to fix build failures with security hardening flags enabled
and with some systemd configuration (underlink)
- 481.patch
- 482.patch

Add new dlt-adaptor-stdin cmake optional flag
Drop PV variable, not needed anymore
Drop latomic manual added flag, upstream code changed to avoid its need
See: COVESA/dlt-daemon#433 and COVESA/dlt-daemon@2224cdd
(changed from atomic_bool to atomic_int, the latter doesn't require manual atomic library link since
it can be optimized properly by the compiler on riscv platforms)

What's Changed:

    dlt-system: fix a libc buffer overflow detection on 32bit targets by @mtitinger in #337
    dlt-daemon: create sockets using "android way" by @sebastienraillet in #333
    fixes compilation issue with clang by @sebastienraillet in #339
    dlt-daemon: Only create directories if they do not exist yet by @alexmohr in #340
    dlt-system : fix invalid free with ConfigurationFileName by @mtitinger in #342
    fix for the issue #341 by @rvalovyi in #347
    Forcibly the severity level set by @dhnatiuk1 in #346
    fix -Wformat issues reported by clang by @sebastienraillet in #349
    dlt-system: fix invalid free by removing unused TempDir by @andreirusu96 in #350
    Support for Cygwin toolchain. by @DoctorNoobingstoneIPresume in #351
    filetransfer: Return error if no free space by @ssugiura in #354
    lib: Correct VARI usage in dlt_user_log_write_uint by @ssugiura in #356
    Fix DLT User/Client tests by @andreirusu96 in #357
    tests: Deplicate unused files and variables by @ssugiura in #359
    Fix the target name in documentation by @mawillers in #372
    cmake: Add option to enable each adaptor by itself by @alexmohr in #364
    cmake: Add options to enable/disable each dlt console tool by @alexmohr in #363
    filetransfer: Fix getFileCreationDate2 stat check by @andreirusu96 in #361
    dlt_config_file_parser.c:Fix a pointer release bug in the file。 by @Leslie-bcy in #376
    Update workflow by @thanhbnq in #389
    README: Update link to github actions by @ssugiura in #392
    Fix handle returned value by @thanhbnq in #384
    systemd: install adaptor-udp service for adaptor=on by @danielweber2018 in #393
    automotive-dlt.pc: add the path to find the static library by @zeerd in #387
    enforce-trace-limit: ContextLogLevel is now enforced in the daemon by @alexmohr in #382
    dlt-daemon-connection: Start up even if not all bindings are valid by @alexmohr in #380
    dlt_common.c: Change default logging_mode by @wusto in #406
    logstorage: Truncate ECUid in Logstorage filter to prevent crash by @andreirusu96 in #402
    Update dlt_for_developers.md by @marques-bruno in #405
    dlt-gateway: Fix crash on invalid ip by @alexmohr in #381
    dlt_client:Block in connect() by @thanhbnq in #409
    dlt_daemon_client: Fix change loglevel of application by @lti9hc in #408
    Update maintainer by @thanhbnq in #410
    systemd: add support for socket activation via systemd by @alexmohr in #401
    internal-logging: Fix issues with file logging by @alexmohr in #378
    dlt_common: change output of message for log initialization by @lti9hc in #412
    Avoid memory corruption behind buffer wp in function dlt_getloginfo_conv_ascii_to_id by @michael-methner in #411
    dlt_daemon_client: Fix Control Msg ECUId comparison with active Gateway by @andreirusu96 in #414
    Fix for Resource and Memory Leak by @lti9hc in #418
    dlt-receive: set host interface and allow multiple udp multicast addresses by @thanhbnq in #420
    dlt-system: Fix buffer overflow detection on 32bit targets by @sandy-lcq in #398
    cmake: network trace enable toggle by @danielweber2018 in #424
    client: Fix Get Log Info response conversion method by @andreirusu96 in #422
    filetransfer: fix filesize divisible by blocksize case by @danielweber2018 in #383
    Updates for Coding Styles by @thanhbnq in #425
    gateway: Fix Node handling and ECUid checks by @andreirusu96 in #429
    Update contacts and removed mailing lists by @michael-methner in #431
    dlt-user: Fix crashes in dlt_free during dlt_init by @alexmohr in #362
    dlt-convert: Fix memory leak by calling dlt_file_free by @lvklevankhanh in #434
    dlt-user: fix potential non closed socket in init/free by @alexmohr in #435
    Check for negative index in dlt_file_message by @michael-methner in #437
    Fix memory leak by @lvklevankhanh in #441
    dlt-connection: add socket timeout by @alexmohr in #439
    Installs dlt.conf on android by @sebastienraillet in #446
    This changes a mispatch from fcb676a to install udp binary correctly by @smooge in #449
    logfile: exhance internal dlt logging by introducing size limits by @danielweber2018 in #369
    dlt-logd-converter: fixes android 12 compilation by @sebastienraillet in #445
    dlt-logd-converter: Fix getting log level from log msg by @RobinChenJP in #456
    house-keeper: remove infinite wait by @alexmohr in #438
    cmake: remove duplicated option message by @minminlittleshrimp in #454
    Android: Add new feature in Android bp by @minminlittleshrimp in #461
    dlt_multiple_files: remove superfluous mode bits and add header file to header list by @minminlittleshrimp in #462
    dlt-user: fix crash with certain strings by @alexmohr in #463

Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants