Skip to content

Simplifying needed sass assets for xmodule sass compilation - #9834

Merged
talbs merged 1 commit into
ned/fix-xmodule-scssfrom
talbs/fix-xmodule-scss
Sep 21, 2015
Merged

Simplifying needed sass assets for xmodule sass compilation#9834
talbs merged 1 commit into
ned/fix-xmodule-scssfrom
talbs/fix-xmodule-scss

Conversation

@talbs

@talbs talbs commented Sep 18, 2015

Copy link
Copy Markdown
Contributor

This work simplifies the amount of Sass imports needed to resolve an xmodule missing sass variable compilation error happening in the sass-theming branch currently.


Reviewers

@singingwolfboy

Copy link
Copy Markdown
Contributor

👍

@talbs

talbs commented Sep 18, 2015

Copy link
Copy Markdown
Contributor Author

Also, once this is merged, feel free to squash it with your other commits (hence the fixup!)

@nedbat

nedbat commented Sep 21, 2015

Copy link
Copy Markdown
Contributor

If this fixes the problem, and @talbs likes it, then I like it. 👍

talbs added a commit that referenced this pull request Sep 21, 2015
Simplifying needed sass assets for xmodule sass compilation
@talbs
talbs merged commit 553804d into ned/fix-xmodule-scss Sep 21, 2015
@talbs
talbs deleted the talbs/fix-xmodule-scss branch September 21, 2015 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants