Import the correct scss files for xmodule styling - #9818
Conversation
|
@singingwolfboy @talbs this fixes the error, but I don't know if it's right. |
|
jenkins run bokchoy |
|
@singingwolfboy thanks for the in-person walkthrough. bat I've experimented a bit in simplifying the amount of sass imports needed to avoid the missing variable error found during compilation. Here's a PR with that adjustment - https://github.com/edx/edx-platform/pull/9834. @nedbat, let me know if there's any specific reason you needed the other imports in your original solution. Happy to keep them, as they are good general utilities to include, if there's a specific need. |
|
@talbs I included everything that was included at the top of courses.scss (or some file like that). I didn't try to whittle it down. I'm fine with your svelter fix. |
Simplifying needed sass assets for xmodule sass compilation
|
Thanks for the 4-1-1, @nedbat. I just merged my sveltness into this branch. Feel free to rebase to squash that commit into your work. Once that's done and tests pass, you will have my gratitude and my 👍 . |
|
jenkins run quality |
Import the correct scss files for xmodule styling
No description provided.