I18n fix by Tsinghua - #672
Conversation
|
first commit is also mine...forgot to change the username |
There was a problem hiding this comment.
django.utils.translation.ugettext should be imported as _ and used here, so that the translation extraction code will pick up these strings to extract.
There was a problem hiding this comment.
This HTML seems to be inserted directly. Import statement may course some problems...
We copied these strings to another js file to let them be picked.
ghost
assigned
There was a problem hiding this comment.
Please use the "format" method for string substitution
Conflicts: cms/djangoapps/contentstore/views/assets.py lms/templates/registration/password_reset_complete.html lms/templates/registration/password_reset_confirm.html
|
% to format fixed |
There was a problem hiding this comment.
While we're here, can we drop the elite "e.g." in favor of "for example" ?
|
"e.g." changed to "Example" ... is it OK? |
|
@dfnjy "e.g. FooBar" should become, "for example, FooBar" or "FooBar, for example," but I didn't mean for you to correct the English, that's should be on us. |
|
@nedbat All right. Is everything corrected now? |
6 participants
I fixed some i18n bugs which are obvious and easiest to fix. Most of them are in HTML templates.
Including following fixes:
cms/djangoapps/contentstore/views/assets.py
cms/static/client_templates/course_grade_policy.html
cms/templates/asset_index.html
cms/templates/widgets/units.html
common/djangoapps/student/views.py
lms/templates/dashboard.html
lms/templates/forgot_password_modal.html
lms/templates/login.html
cms/templates/index.html
lms/templates/courseware/course_about.html
lms/templates/registration/password_reset_complete.html
lms/templates/registration/password_reset_confirm.html