Auto-enroll course staff to fix "View Live".

[cahrens]

STUD-554

Add test points to existing BDD specs:

https://edx-wiki.atlassian.net/wiki/display/STU/Course+Creation+BDD
https://edx-wiki.atlassian.net/wiki/display/STU/Course+Team+BDD+spec

[singingwolfboy]

I think this would be easier to read and understand:

def _get_course_id(self, test_course_data):
    """Returns the course ID (org/number/run)."""
    return "{org}/{number}/{run}".format(**test_course_data)

[cahrens]

Will do.

[singingwolfboy]

BTW: here is the documention for Pythons **data form

[cahrens]

@chrisndodge I added the helper methods. I decided to preface them with "_", though I'm not entirely sure that is appropriate.

[chrisndodge]

@cahrens I believe the '' is to mark a method as 'private', but I'm not sure. So if it is being called from an external python module, then my sense is that it shouldn't have a ''. @nedbat is probably the right perform to ask about that.

[cahrens]

@chrisndodge I believe you are correct. We just sometimes use "_" for "private to us/I'm feeling a little dirty" methods. But I went ahead and removed the _ prefix (and rebased).

[chrisndodge]

I see a try/catch in the LMS side call to this method. Do you know why it is needed there but not similarly in the CMS?

[cahrens]

This is the comment in the catch statement--

        # If we've already created this enrollment in a separate transaction,
        # then just continue

This certainly won't be the case in the CMS code path. In reality, I don't see how it is ever an issue because the method get_or_create returns the registration if the user is already registered, and else creates the registration. In other words, it is robust to call the method even if the user is already registered for the course. In fact, I have a unit test that does this to make sure there is no error.

[markchang]

I just tested this on local dev and seemed to work as expected. New courses created get auto enroll.

[chrisndodge]

Thanks! Nice work!

+1

[singingwolfboy]

👍