POST requests were claiming request.method == 'PUT' - #441
Merged
Conversation
Contributor
|
Can you add a comment around the in ['POST', 'PUT'] check. I say this because someone didn't know that was required and removed that code, so having a comment might prevent that. |
Contributor
|
Also, add a unit test that recreates the error (when the fix isn't there) and then passed when the fix is there. |
added 2 commits
July 19, 2013 11:12
So, changed handlers to look for either value.
Contributor
Author
|
Added test forcing headers to the values I saw and added comments. |
Contributor
|
Looks good. 👍 |
Contributor
|
+1 |
dmitchell
added a commit
that referenced
this pull request
Jul 19, 2013
POST requests were claiming request.method == 'PUT'
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…scroll Add jQuery scrollTo to courseware.
e-kolpakov
referenced
this pull request
in open-craft/openedx-platform
May 15, 2015
Cdodge/digest support
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
Load elasticsearch config from JSON
xavierchan
pushed a commit
to xavierchan/edx-platform-1
that referenced
this pull request
May 30, 2019
jbcurtin
pushed a commit
to jbcurtin/edx-platform
that referenced
this pull request
Jan 31, 2022
…to registration form (openedx#441) * feat: add `optional-exposed` extra field type to registration form This defines optional extra fields that are not hidden under the toggle on the registration page. (cherry picked from commit 230795f) Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * Fix use a registration field order when using a registration extension form (openedx#26633) (cherry-picked from commit 6f0255b) Co-authored-by: Ivo Branco <igobranco@gmail.com>
Danyal-Faheem
pushed a commit
to Danyal-Faheem/edx-platform
that referenced
this pull request
Jul 15, 2025
* feat: bypass course filtering rules set of lms in admin dashboard * feat: add new column to all courses enrollment report * feat: add users enrollment report in admin dashboard * feat: rearrange admin reports * feat: add grade report in student admin tab * Relocate and simplify grade and certificates instructor reports * allow course staff to access data download section --------- Co-authored-by: Abdul-Muqadim-Arbisoft <139064778+Abdul-Muqadim-Arbisoft@users.noreply.github.com> Co-authored-by: Abdul-Muqadim-Arbisoft <abdul.muqadim@arbisoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, changed handlers to look for either value.
There were already unit tests which didn't fail tho; so, rewriting happened someplace outside of django unit test encapsulation of .post..
Fixing https://edx-wiki.atlassian.net/browse/STUD-441, https://edx-wiki.atlassian.net/browse/STUD-471
@cdodge @peter-fogg please review