Use registration field order when using a registration extension form by igobranco · Pull Request #26633 · openedx/openedx-platform

igobranco · 2021-02-19T15:29:32Z

Description

On registration screen, make it possible to change the REGISTRATION_FIELD_ORDER when using a custom REGISTRATION_EXTENSION_FORM.

If you are managing an open edx installation probably you need to ask more information about your users on the registration form. For that you use a registration extension form. But when you configure that extension form you no longer can change the ordering of presentation of each field on the registration form. This pull request tries to fix that specific thing.

This change has impact for Developers and Operators that manage a custom open edx installation.

Example, with this configuration, we can

REGISTRATION_EXTRA_FIELDS:
    city: required
    confirm_email: hidden
    country: required
    gender: optional
    goals: optional
    honor_code: required
    level_of_education: optional
    mailing_address: hidden
    year_of_birth: optional
    terms_of_service: hidden
    data_authorization: required # custom registration field
    employment_situation: optional # custom registration field
    allow_newsletter: optional # custom registration field

REGISTRATION_FIELD_ORDER:
- email
- name
- username
- password
- data_authorization # custom registration field
- honor_code
- city
- country
- allow_newsletter # custom registration field
- gender
- year_of_birth
- level_of_education
- employment_situation # custom registration field
- goals

Required fields:

Optional fields:

openedx-webhooks · 2021-02-19T15:29:37Z

Thanks for the pull request, @igobranco! I've created OSPR-5632 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

natabene · 2021-02-22T15:49:09Z

@igobranco Thank you for the contribution! When you have a chance, could you please send in a signed Contributor Agreement mentioned in the earlier comment? You only need to do this once and we can then review all your future code contributions. Thanks

natabene · 2021-03-10T19:03:42Z

@igobranco We now have the same agreement available in Docusign here, so you don't need to print. Please sign when you have a chance.

natabene · 2021-03-19T20:53:57Z

@igobranco Thank you for joining the Open edX community! We have added your user to our records and can now review your code going forward.

natabene · 2021-03-19T20:54:02Z

jenkins run all

natabene · 2021-05-24T15:24:48Z

@igobranco Could you please look into the failing tests?

natabene · 2021-06-01T15:20:36Z

jenkins run all

natabene · 2021-06-01T18:42:16Z

@wajeeha-khalid Could you please provide early feedback once you have a chance?

wajeeha-khalid · 2021-06-02T11:36:09Z

@waheedahmed ^^ review required
I don't see any product concern on this as far as it does not impact the default order of fields

igobranco · 2021-06-02T13:12:20Z

@natabene and @waheedahmed thank you with your information. So I'm going to try to fix the tests and update this pull request.
On previous months, I hadn't have much time to review this PR. I'm kind of new to django, so I had a problems running the tests, but now I think that could run them.

igobranco · 2021-06-02T16:21:37Z

jenkins run all

natabene · 2021-06-02T16:28:27Z

jenkins run all

arch-bom-gocd-alerts · 2021-06-11T18:02:45Z

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build.

We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master.

This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself:

git merge-base --is-ancestor 2e335653 igobranco/registration-field-order-with-form && echo "You're all set" || echo "Please rebase onto master or merge master to your branch"

If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal).

igobranco · 2021-07-12T14:00:27Z

Hi @natabene finally the jenkins didn't end with my errors or other errors ! I've been fetching from upstream a couple of time because the last builds stopped with completed strange errors. Can you help so anyone from edX could validate the changes ?

natabene · 2021-07-14T14:56:30Z

@waheedahmed Could you validate please?

waheedahmed · 2021-08-02T09:30:42Z

@natabene sure, taking a look.

waheedahmed

@natabene I have verified and tested these changes locally and looks good to me.

waheedahmed · 2021-08-02T11:08:58Z

@igobranco Thank you for making these changes! Please squash your commits and make sure your branch is rebased with the latest master.

gabor-boros · 2021-09-21T17:16:28Z

Hey @igobranco, are you still interested in this change? If not, I'd be happy to continue squashing and rebasing as we need this change too.

cc: @waheedahmed

waheedahmed · 2021-09-22T10:52:17Z

@natabene Are we good to move forward and merge this PR or any further step is required here?

…n form

natabene · 2021-09-22T14:23:49Z

@waheedahmed If the author @igobranco is ready, no problem from my side.

edx-status-bot · 2021-09-22T14:42:39Z

Your PR has finished running tests. There were no failures.

igobranco · 2021-09-22T14:43:29Z

@waheedahmed I've updated the PR: rebased and squashed the commits.

cc @gabor-boros

waheedahmed · 2021-09-23T06:06:20Z

Thank you @natabene and @igobranco!

Merging it now. Thanks again, everyone!

openedx-webhooks · 2021-09-23T06:07:53Z

@igobranco 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-pipeline-bot · 2021-09-23T07:18:05Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2021-09-23T08:10:21Z

EdX Release Notice: This PR has been deployed to the production environment.

alfredchavez · 2021-10-26T23:40:51Z

@gabor-boros could you port this changes to lilac.master? as part of BB-4877
CC: @arbrandes for review

…n form (openedx#26633) (cherry-picked from commit 6f0255b)

…to registration form (#441) * feat: add `optional-exposed` extra field type to registration form This defines optional extra fields that are not hidden under the toggle on the registration page. (cherry picked from commit 230795f) Signed-off-by: Gabor Boros <gabor.brs@gmail.com> * Fix use a registration field order when using a registration extension form (openedx#26633) (cherry-picked from commit 6f0255b) Co-authored-by: Ivo Branco <igobranco@gmail.com>

openedx-webhooks added community manager review open-source-contribution PR author is not from Axim or 2U labels Feb 19, 2021

openedx-webhooks added the changes requested label Mar 22, 2021

openedx-webhooks removed the community manager review label May 25, 2021

openedx-webhooks added awaiting prioritization and removed changes requested labels Jul 14, 2021

waheedahmed approved these changes Aug 2, 2021

View reviewed changes

openedx-webhooks added ready to merge and removed awaiting prioritization labels Aug 2, 2021

Fix use a registration field order when using a registration extensio…

baf0207

…n form

igobranco force-pushed the igobranco/registration-field-order-with-form branch from 53e8301 to baf0207 Compare September 22, 2021 14:00

waheedahmed merged commit 6f0255b into openedx:master Sep 23, 2021

openedx-webhooks added the merged label Sep 23, 2021

gabor-boros mentioned this pull request Oct 1, 2021

[SE-4888] Cherry-pick Fix use a registration field order when using a registration extension open-craft/openedx-platform#419

Merged

gabor-boros pushed a commit to open-craft/openedx-platform that referenced this pull request Nov 15, 2021

Fix use a registration field order when using a registration extensio…

d6336ac

…n form (openedx#26633) (cherry-picked from commit 6f0255b)

Uh oh!

Conversation

igobranco commented Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openedx-webhooks commented Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natabene commented Feb 22, 2021

Uh oh!

natabene commented Mar 10, 2021

Uh oh!

natabene commented Mar 19, 2021

Uh oh!

natabene commented Mar 19, 2021

Uh oh!

natabene commented May 24, 2021

Uh oh!

natabene commented Jun 1, 2021

Uh oh!

natabene commented Jun 1, 2021

Uh oh!

wajeeha-khalid commented Jun 2, 2021

Uh oh!

igobranco commented Jun 2, 2021

Uh oh!

igobranco commented Jun 2, 2021

Uh oh!

natabene commented Jun 2, 2021

Uh oh!

arch-bom-gocd-alerts commented Jun 11, 2021

Uh oh!

igobranco commented Jul 12, 2021

Uh oh!

natabene commented Jul 14, 2021

Uh oh!

waheedahmed commented Aug 2, 2021

Uh oh!

waheedahmed left a comment

Choose a reason for hiding this comment

Uh oh!

waheedahmed commented Aug 2, 2021

Uh oh!

gabor-boros commented Sep 21, 2021

Uh oh!

waheedahmed commented Sep 22, 2021

Uh oh!

natabene commented Sep 22, 2021

Uh oh!

edx-status-bot commented Sep 22, 2021

Uh oh!

igobranco commented Sep 22, 2021

Uh oh!

waheedahmed commented Sep 23, 2021

Uh oh!

openedx-webhooks commented Sep 23, 2021

Uh oh!

edx-pipeline-bot commented Sep 23, 2021

Uh oh!

edx-pipeline-bot commented Sep 23, 2021

Uh oh!

alfredchavez commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

igobranco commented Feb 19, 2021 •

edited

Loading

openedx-webhooks commented Feb 19, 2021 •

edited

Loading

alfredchavez commented Oct 26, 2021 •

edited

Loading